diff options
| author | Rudolf Marek <r.marek@assembler.cz> | 2012-04-22 23:52:23 +0200 |
|---|---|---|
| committer | Peter Stuge <peter@stuge.se> | 2012-04-23 00:48:22 +0200 |
| commit | eeb8a06b037ff9fbd0877e6660ec23038b1f7448 (patch) | |
| tree | 3dd74b93681ede907fb9d51156fb0161acb343e3 | |
| parent | 770c44d20ff10fc962760b9a85626bb43c6ba083 (diff) | |
| download | coreboot-eeb8a06b037ff9fbd0877e6660ec23038b1f7448.tar.xz | |
Unbreak boards where chipset can select between FSB and serial APIC bus
Commit d4d5e4d3e10da06a83d57a147bd58a733381de18 contains #ifdef instead
of #if, making the FSB/serial bus selection for APIC always select serial
bus. The bug is harmless on most chipsets because the bit is often RO,
but it breaks at least on VIA K8T890.
Change-Id: I89c4855922199eca7f921c3e4eb500656544c8e5
Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Reviewed-on: http://review.coreboot.org/921
Tested-by: build bot (Jenkins)
Reviewed-by: Peter Stuge <peter@stuge.se>
| -rw-r--r-- | src/arch/x86/lib/ioapic.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/arch/x86/lib/ioapic.c b/src/arch/x86/lib/ioapic.c index e974d7cce6..57b99e283e 100644 --- a/src/arch/x86/lib/ioapic.c +++ b/src/arch/x86/lib/ioapic.c @@ -89,7 +89,7 @@ void setup_ioapic(u32 ioapic_base, u8 ioapic_id) ioapic_interrupts = 24; printk(BIOS_DEBUG, "IOAPIC: %d interrupts\n", ioapic_interrupts); -#ifdef CONFIG_IOAPIC_INTERRUPTS_ON_FSB +#if CONFIG_IOAPIC_INTERRUPTS_ON_FSB /* * For the Pentium 4 and above APICs deliver their interrupts * on the front side bus, enable that. @@ -98,7 +98,7 @@ void setup_ioapic(u32 ioapic_base, u8 ioapic_id) io_apic_write(ioapic_base, 0x03, io_apic_read(ioapic_base, 0x03) | (1 << 0)); #endif -#ifdef CONFIG_IOAPIC_INTERRUPTS_ON_APIC_SERIAL_BUS +#if CONFIG_IOAPIC_INTERRUPTS_ON_APIC_SERIAL_BUS printk(BIOS_DEBUG, "IOAPIC: Enabling interrupts on APIC serial bus\n"); io_apic_write(ioapic_base, 0x03, 0); #endif |