diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-08-30 10:41:25 +0300 |
|---|---|---|
| committer | Furquan Shaikh <furquan@google.com> | 2019-08-31 06:44:59 +0000 |
| commit | fad9536edf408718ddbc65c664652b6c01267568 (patch) | |
| tree | 8a6f91e2d172feaa0c26629353193291903a5d02 | |
| parent | a4ea8b8c18639229e3cb0a4be4fd90e70f9977e4 (diff) | |
| download | coreboot-fad9536edf408718ddbc65c664652b6c01267568.tar.xz | |
arch/x86: Remove WB attribute from 0..CACHE_TMP_RAMTOP
Platforms using postcar are with RELOCATABLE_RAMSTAGE=y. They
don't benefit from having low-memory set as writeback-cacheable.
This also fixes regression from CB:34893 that caused some random
hangs with more recent intel SoCs in ramstage.
BUG=b:140250314
Change-Id: Ia66910a6c85286f5c05823b87d48edc7e4ad9541
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35161
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
| -rw-r--r-- | src/arch/x86/postcar_loader.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/arch/x86/postcar_loader.c b/src/arch/x86/postcar_loader.c index 6a7d389ea3..61a9d52cd8 100644 --- a/src/arch/x86/postcar_loader.c +++ b/src/arch/x86/postcar_loader.c @@ -125,9 +125,6 @@ void postcar_frame_common_mtrrs(struct postcar_frame *pcf) if (pcf->skip_common_mtrr) return; - /* Cache RAM as WB from 0 -> CACHE_TMP_RAMTOP. */ - postcar_frame_add_mtrr(pcf, 0, CACHE_TMP_RAMTOP, MTRR_TYPE_WRBACK); - /* Cache the ROM as WP just below 4GiB. */ postcar_frame_add_romcache(pcf, MTRR_TYPE_WRPROT); } |