summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Stuge <peter@stuge.se>2009-01-26 17:18:31 +0000
committerPeter Stuge <peter@stuge.se>2009-01-26 17:18:31 +0000
commit3108a12e9b701e6c3daeb0ae629ecb603dd6509c (patch)
treec5a1455804e58d611f6d0a0134193754809e4cd5
parentc1d6ed9a21bc96b0d4eb778b78c65b304e5e46f9 (diff)
downloadcoreboot-3108a12e9b701e6c3daeb0ae629ecb603dd6509c.tar.xz
msrtool: Allow MSR symbols (names) to also be used as addresses.
Thanks for the idea Mart! Signed-off-by: Peter Stuge <peter@stuge.se> Acked-by: Peter Stuge <peter@stuge.se> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3921 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
-rw-r--r--util/msrtool/msrtool.c4
-rw-r--r--util/msrtool/msrtool.h1
-rw-r--r--util/msrtool/msrutils.c16
3 files changed, 19 insertions, 2 deletions
diff --git a/util/msrtool/msrtool.c b/util/msrtool/msrtool.c
index 5742a1765c..bafb0908c0 100644
--- a/util/msrtool/msrtool.c
+++ b/util/msrtool/msrtool.c
@@ -278,7 +278,7 @@ int main(int argc, char *argv[]) {
break;
case 'i':
input = 1;
- addr = strtoul(optarg, NULL, 16);
+ addr = msraddrbyname(optarg);
optarg = strchr(optarg, '=');
if (NULL == optarg) {
fprintf(stderr, "missing value in -i argument!\n");
@@ -398,7 +398,7 @@ int main(int argc, char *argv[]) {
}
for (; optind < argc; optind++) {
- addr = strtoul(argv[optind], NULL, 16);
+ addr = msraddrbyname(argv[optind]);
if (!sys->rdmsr(cpu, addr, &msrval))
break;
decodemsr(cpu, addr, msrval);
diff --git a/util/msrtool/msrtool.h b/util/msrtool/msrtool.h
index 7b639f0657..23bc4b88d2 100644
--- a/util/msrtool/msrtool.h
+++ b/util/msrtool/msrtool.h
@@ -157,6 +157,7 @@ struct msr msr_shl(const struct msr a, const uint8_t bits);
struct msr msr_shr(const struct msr a, const uint8_t bits);
void msr_and(struct msr *a, const struct msr b);
const struct msrdef *findmsrdef(const uint32_t addr);
+const uint32_t msraddrbyname(const char *name);
void dumpmsrdefs(const struct targetdef *t);
int dumpmsrdefsvals(FILE *f, const struct targetdef *t, const uint8_t cpu);
uint8_t str2msr(char *str, struct msr *msr);
diff --git a/util/msrtool/msrutils.c b/util/msrtool/msrutils.c
index c5fcbea143..4a4782b687 100644
--- a/util/msrtool/msrutils.c
+++ b/util/msrtool/msrutils.c
@@ -137,6 +137,22 @@ const struct msrdef *findmsrdef(const uint32_t addr) {
return NULL;
}
+const uint32_t msraddrbyname(const char *name) {
+ uint8_t t;
+ const uint32_t addr = strtoul(name, NULL, 16);
+ const struct msrdef *m;
+ if (!targets)
+ return 0;
+ for (t = 0; t < targets_found; t++)
+ for (m = targets[t]->msrs; !MSR_ISEOT(*m); m++) {
+ if (addr == m->addr)
+ return m->addr;
+ if (!strcasecmp(name, m->symbol))
+ return m->addr;
+ }
+ return 0;
+}
+
void dumpmsrdefs(const struct targetdef *t) {
const struct msrdef *m;
const struct msrbits *mb;