summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAaron Durbin <adurbin@chromium.org>2014-02-18 19:36:05 -0600
committerAaron Durbin <adurbin@google.com>2014-03-03 23:25:53 +0100
commit3f7ad7b216b4021c7cb93201a94b0fae46f5e19e (patch)
treec48ac8ce036cc5be5029e6089e583f2d8746aa8c
parentb013c279a93627c7edeb10cb5b976483e61166d9 (diff)
downloadcoreboot-3f7ad7b216b4021c7cb93201a94b0fae46f5e19e.tar.xz
coreboot: don't return struct lb_memory * from write_tables()
No one is interrogating the write_tables() return value. Therefore, drop it. Change-Id: I97e707f071942239c9a0fa0914af3679ee7a9c3c Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: http://review.coreboot.org/5301 Tested-by: build bot (Jenkins) Reviewed-by: Vladimir Serbinenko <phcoder@gmail.com>
-rw-r--r--src/arch/armv7/tables.c6
-rw-r--r--src/arch/x86/boot/tables.c4
-rw-r--r--src/include/boot/tables.h2
3 files changed, 4 insertions, 8 deletions
diff --git a/src/arch/armv7/tables.c b/src/arch/armv7/tables.c
index 7e7cbe409c..20c5a9f7a8 100644
--- a/src/arch/armv7/tables.c
+++ b/src/arch/armv7/tables.c
@@ -46,7 +46,7 @@ void cbmem_fail_resume(void)
{
}
-struct lb_memory *write_tables(void)
+void write_tables(void)
{
unsigned long table_pointer, new_table_pointer;
@@ -56,7 +56,7 @@ struct lb_memory *write_tables(void)
MAX_COREBOOT_TABLE_SIZE);
if (!table_pointer) {
printk(BIOS_ERR, "Could not add CBMEM for coreboot table.\n");
- return NULL;
+ return;
}
new_table_pointer = write_coreboot_table(0UL, 0UL,
@@ -74,6 +74,4 @@ struct lb_memory *write_tables(void)
/* Print CBMEM sections */
cbmem_list();
-
- return get_lb_mem();
}
diff --git a/src/arch/x86/boot/tables.c b/src/arch/x86/boot/tables.c
index e980ed816c..42e431e06e 100644
--- a/src/arch/x86/boot/tables.c
+++ b/src/arch/x86/boot/tables.c
@@ -38,7 +38,7 @@ void cbmem_arch_init(void)
move_gdt();
}
-struct lb_memory *write_tables(void)
+void write_tables(void)
{
unsigned long low_table_start, low_table_end;
unsigned long rom_table_start, rom_table_end;
@@ -244,6 +244,4 @@ struct lb_memory *write_tables(void)
/* Print CBMEM sections */
cbmem_list();
-
- return get_lb_mem();
}
diff --git a/src/include/boot/tables.h b/src/include/boot/tables.h
index f9e91a4e18..e86adfc27b 100644
--- a/src/include/boot/tables.h
+++ b/src/include/boot/tables.h
@@ -3,6 +3,6 @@
#include <boot/coreboot_tables.h>
-struct lb_memory *write_tables(void);
+void write_tables(void);
#endif /* BOOT_TABLES_H */