diff options
| author | Patrick Georgi <patrick@georgi-clan.de> | 2015-02-22 16:21:01 +0100 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2015-02-23 20:33:45 +0100 |
| commit | 477b4c539a5c05a0ccdf11b68fdff78b2ebe56cb (patch) | |
| tree | 8620bdf9d0cc316b0ec77259d27ec1d041fc0cf7 | |
| parent | b4ad5d0a93e60e887bcda9819597954e72115272 (diff) | |
| download | coreboot-477b4c539a5c05a0ccdf11b68fdff78b2ebe56cb.tar.xz | |
AMD Fam10h: Don't write uninitialized data into ACPI
The goto statement skipped all the code that is necessary
to fill in the data structures that are read right after
the jump.
Since there doesn't seem to be useful data, why write these
ACPI objects in the first place?
Change-Id: I1d06c11a7a31517b81e54159355d5c27e3cc3735
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Found-by: Coverity Scan
Reviewed-on: http://review.coreboot.org/8507
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Timothy Pearson <tpearson@raptorengineeringinc.com>
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
| -rw-r--r-- | src/cpu/amd/model_10xxx/powernow_acpi.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/cpu/amd/model_10xxx/powernow_acpi.c b/src/cpu/amd/model_10xxx/powernow_acpi.c index 8b3ae37ba5..0b3681cbb1 100644 --- a/src/cpu/amd/model_10xxx/powernow_acpi.c +++ b/src/cpu/amd/model_10xxx/powernow_acpi.c @@ -145,7 +145,7 @@ static void pstates_algorithm(u32 pcontrol_blk, u8 plen, u8 onlyBSP) cpuid1 = cpuid(0x80000007); if ((cpuid1.edx & 0x80) != 0x80) { printk(BIOS_INFO, "No valid set of P-states\n"); - goto write_pstates; + return; } uint8_t pviModeFlag; @@ -258,7 +258,6 @@ static void pstates_algorithm(u32 pcontrol_blk, u8 plen, u8 onlyBSP) Pstate_latency[index]); } -write_pstates: for (index = 0; index < cmp_cap; index++) write_pstates_for_core(Pstate_num, Pstate_feq, Pstate_power, Pstate_latency, Pstate_control, Pstate_status, |