summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2020-05-30 17:49:58 +0300
committerPatrick Georgi <pgeorgi@google.com>2020-06-07 21:45:20 +0000
commit4812cf96c2d099c58e779a0859d3a2c47ae27804 (patch)
tree3b5135fcb87a1710aad19b9eed0dd69d8dcbd732
parentf9aac92880829c5da2a594740142a4c98406d7f9 (diff)
downloadcoreboot-4812cf96c2d099c58e779a0859d3a2c47ae27804.tar.xz
acpi,mb/*: Use motherboard_fill_fadt()
By vendor choice override fadt->preferred_pm_profile here. Change-Id: I0453c0edc9aeb86cf4f5d912613b8fa8beb63ab4 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/41917 Reviewed-by: Wim Vervoorn <wvervoorn@eltan.com> Reviewed-by: Frans Hendriks <fhendriks@eltan.com> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/facebook/fbg1701/acpi_tables.c6
-rw-r--r--src/mainboard/facebook/fbg1701/fadt.c4
-rw-r--r--src/mainboard/portwell/m107/acpi_tables.c6
-rw-r--r--src/mainboard/portwell/m107/fadt.c4
-rw-r--r--src/mainboard/protectli/vault_bsw/acpi_tables.c6
-rw-r--r--src/mainboard/protectli/vault_bsw/fadt.c4
6 files changed, 21 insertions, 9 deletions
diff --git a/src/mainboard/facebook/fbg1701/acpi_tables.c b/src/mainboard/facebook/fbg1701/acpi_tables.c
index 539a74e8a8..8492704b74 100644
--- a/src/mainboard/facebook/fbg1701/acpi_tables.c
+++ b/src/mainboard/facebook/fbg1701/acpi_tables.c
@@ -37,3 +37,9 @@ unsigned long acpi_fill_madt(unsigned long current)
return current;
}
+
+void motherboard_fill_fadt(acpi_fadt_t *fadt)
+{
+ fadt->preferred_pm_profile = PM_MOBILE;
+ fadt->iapc_boot_arch &= ~ACPI_FADT_8042;
+}
diff --git a/src/mainboard/facebook/fbg1701/fadt.c b/src/mainboard/facebook/fbg1701/fadt.c
index 3785f15d8f..cd15725a98 100644
--- a/src/mainboard/facebook/fbg1701/fadt.c
+++ b/src/mainboard/facebook/fbg1701/fadt.c
@@ -18,7 +18,6 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
fadt->firmware_ctrl = (unsigned long) facs;
fadt->dsdt = (unsigned long) dsdt;
- fadt->preferred_pm_profile = PM_MOBILE;
fadt->x_firmware_ctl_l = (unsigned long)facs;
fadt->x_firmware_ctl_h = 0;
@@ -26,8 +25,7 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
fadt->x_dsdt_h = 0;
acpi_fill_in_fadt(fadt);
-
- fadt->iapc_boot_arch &= ~ACPI_FADT_8042;
+ motherboard_fill_fadt(fadt);
header->checksum =
acpi_checksum((void *) fadt, header->length);
diff --git a/src/mainboard/portwell/m107/acpi_tables.c b/src/mainboard/portwell/m107/acpi_tables.c
index 539a74e8a8..8492704b74 100644
--- a/src/mainboard/portwell/m107/acpi_tables.c
+++ b/src/mainboard/portwell/m107/acpi_tables.c
@@ -37,3 +37,9 @@ unsigned long acpi_fill_madt(unsigned long current)
return current;
}
+
+void motherboard_fill_fadt(acpi_fadt_t *fadt)
+{
+ fadt->preferred_pm_profile = PM_MOBILE;
+ fadt->iapc_boot_arch &= ~ACPI_FADT_8042;
+}
diff --git a/src/mainboard/portwell/m107/fadt.c b/src/mainboard/portwell/m107/fadt.c
index 3785f15d8f..cd15725a98 100644
--- a/src/mainboard/portwell/m107/fadt.c
+++ b/src/mainboard/portwell/m107/fadt.c
@@ -18,7 +18,6 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
fadt->firmware_ctrl = (unsigned long) facs;
fadt->dsdt = (unsigned long) dsdt;
- fadt->preferred_pm_profile = PM_MOBILE;
fadt->x_firmware_ctl_l = (unsigned long)facs;
fadt->x_firmware_ctl_h = 0;
@@ -26,8 +25,7 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
fadt->x_dsdt_h = 0;
acpi_fill_in_fadt(fadt);
-
- fadt->iapc_boot_arch &= ~ACPI_FADT_8042;
+ motherboard_fill_fadt(fadt);
header->checksum =
acpi_checksum((void *) fadt, header->length);
diff --git a/src/mainboard/protectli/vault_bsw/acpi_tables.c b/src/mainboard/protectli/vault_bsw/acpi_tables.c
index f502741f5c..9ecb5ac0b0 100644
--- a/src/mainboard/protectli/vault_bsw/acpi_tables.c
+++ b/src/mainboard/protectli/vault_bsw/acpi_tables.c
@@ -27,3 +27,9 @@ unsigned long acpi_fill_madt(unsigned long current)
return current;
}
+
+void motherboard_fill_fadt(acpi_fadt_t *fadt)
+{
+ fadt->preferred_pm_profile = PM_MOBILE;
+ fadt->iapc_boot_arch = ACPI_FADT_LEGACY_DEVICES;
+}
diff --git a/src/mainboard/protectli/vault_bsw/fadt.c b/src/mainboard/protectli/vault_bsw/fadt.c
index 755ac6e919..2a32c7956c 100644
--- a/src/mainboard/protectli/vault_bsw/fadt.c
+++ b/src/mainboard/protectli/vault_bsw/fadt.c
@@ -19,7 +19,6 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
fadt->firmware_ctrl = (unsigned long)facs;
fadt->dsdt = (unsigned long) dsdt;
- fadt->preferred_pm_profile = PM_MOBILE;
fadt->x_firmware_ctl_l = (unsigned long)facs;
fadt->x_firmware_ctl_h = 0;
@@ -27,8 +26,7 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
fadt->x_dsdt_h = 0;
acpi_fill_in_fadt(fadt);
-
- fadt->iapc_boot_arch = ACPI_FADT_LEGACY_DEVICES;
+ motherboard_fill_fadt(fadt);
header->checksum = acpi_checksum((void *)fadt, header->length);
}