summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAaron Durbin <adurbin@chromium.org>2015-06-09 15:02:50 -0500
committerAaron Durbin <adurbin@chromium.org>2015-06-09 22:25:41 +0200
commit5793b7371dd82ad688164122850d63cdbda56859 (patch)
tree2e0a01dac4bc8e04ea507c65dd79942bb34a290b
parent4f2f01a8fa4035c9c4c73dd7add490915ab4b31c (diff)
downloadcoreboot-5793b7371dd82ad688164122850d63cdbda56859.tar.xz
x86: remove printk() from init_timer()
For console drivers which use udelay() we can deadlock in the printk path on the spinlock. The reason is that on the first call to udelay() from within a console driver it will go back down the printk() path deadlocking oneself. Just remove the printk() as it was asymmetric on romstage vs ramstage. Change-Id: I30fe7d6e5b4684f17d4f353c0816b64f9242de0a Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: http://review.coreboot.org/10483 Reviewed-by: Patrick Georgi <pgeorgi@google.com> Tested-by: build bot (Jenkins)
-rw-r--r--src/cpu/x86/tsc/delay_tsc.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/cpu/x86/tsc/delay_tsc.c b/src/cpu/x86/tsc/delay_tsc.c
index 5aaba90ed9..0ad5d3bbdf 100644
--- a/src/cpu/x86/tsc/delay_tsc.c
+++ b/src/cpu/x86/tsc/delay_tsc.c
@@ -152,10 +152,8 @@ static unsigned long long calibrate_tsc(void)
void init_timer(void)
{
- if (!clocks_per_usec) {
+ if (!clocks_per_usec)
clocks_per_usec = calibrate_tsc();
- printk(BIOS_INFO, "clocks_per_usec: %lu\n", clocks_per_usec);
- }
}
static inline unsigned long get_clocks_per_usec(void)