summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2020-03-15 17:11:18 -0500
committerPatrick Georgi <pgeorgi@google.com>2020-03-17 08:27:06 +0000
commit7790cb680a58bf2a5c869dadbb23fbd6bd680f7d (patch)
tree9fd7b734ebf16efe9461b25cfa31b4b1be8b6796
parent0ae21ff7ff5cee842fd18bbd0e84821f5ab945d8 (diff)
downloadcoreboot-7790cb680a58bf2a5c869dadbb23fbd6bd680f7d.tar.xz
sb/lynxpoint/gpio: fix interrupt storm
On newer kernels (> 4.9 LTS), the GPIO ACPI device's interrupt resource causes an interrupt storm which prevents the CPU from properly idling, significantly increasing power consumption. This was fixed for soc/broadwell (which also supports lynxpoint-lp) by removing the interrupt resource, so apply the same fix here. Original fix: https://chromium-review.googlesource.com/203645 Test: build/boot google/wolf, verify CPU0 idles correctly and power consumption drop via powertop in kernels 4.16.18 and 5.x. Change-Id: Ic4963f2f0225b5f44a7604b0107911640345c855 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/39578 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
-rw-r--r--src/southbridge/intel/lynxpoint/acpi/serialio.asl5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/southbridge/intel/lynxpoint/acpi/serialio.asl b/src/southbridge/intel/lynxpoint/acpi/serialio.asl
index 88138a1d61..2a3c096099 100644
--- a/src/southbridge/intel/lynxpoint/acpi/serialio.asl
+++ b/src/southbridge/intel/lynxpoint/acpi/serialio.asl
@@ -551,8 +551,9 @@ Device (GPIO)
, // ResourceSourceIndex
, // ResourceSource
BAR0)
- Interrupt (ResourceConsumer,
- Level, ActiveHigh, Shared, , ,) {14}
+ // Disabled due to IRQ storm: http://crosbug.com/p/29548
+ //Interrupt (ResourceConsumer,
+ // Level, ActiveHigh, Shared, , , ) {14}
})
Method (_CRS, 0, NotSerialized)