diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-03-31 15:13:07 +1100 |
|---|---|---|
| committer | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2014-04-02 01:08:09 +0200 |
| commit | 880e5248dc625f00fe3bc83d13b88730020d577a (patch) | |
| tree | 065448ed4c5edf7a8fb9f3f6bda6c460fce99efb | |
| parent | ade70a0482fa4ed36d8d2d75f190876ccd7cbad5 (diff) | |
| download | coreboot-880e5248dc625f00fe3bc83d13b88730020d577a.tar.xz | |
superio/fintek/f71872: Avoid .c includes
Following the same reasoning as commit
d304331 superio/fintek/f81865f: Avoid .c includes
Clean up the early_serial #include directives in mainboard/romstage code.
Change-Id: Ia021229154dc90b830a314f3adc2a0dd444bd68d
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5436
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
| -rw-r--r-- | src/superio/fintek/f71872/Makefile.inc | 1 | ||||
| -rw-r--r-- | src/superio/fintek/f71872/chip.h | 2 | ||||
| -rw-r--r-- | src/superio/fintek/f71872/early_serial.c | 3 | ||||
| -rw-r--r-- | src/superio/fintek/f71872/f71872.h | 4 |
4 files changed, 7 insertions, 3 deletions
diff --git a/src/superio/fintek/f71872/Makefile.inc b/src/superio/fintek/f71872/Makefile.inc index ed40eb0ab5..58ba5d562a 100644 --- a/src/superio/fintek/f71872/Makefile.inc +++ b/src/superio/fintek/f71872/Makefile.inc @@ -18,4 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_FINTEK_F71872) += early_serial.c ramstage-$(CONFIG_SUPERIO_FINTEK_F71872) += superio.c diff --git a/src/superio/fintek/f71872/chip.h b/src/superio/fintek/f71872/chip.h index a6ac51fe45..3368ef2fdc 100644 --- a/src/superio/fintek/f71872/chip.h +++ b/src/superio/fintek/f71872/chip.h @@ -28,4 +28,4 @@ struct superio_fintek_f71872_config { struct pc_keyboard keyboard; }; -#endif +#endif /* SUPERIO_FINTEK_F71872_CHIP_H */ diff --git a/src/superio/fintek/f71872/early_serial.c b/src/superio/fintek/f71872/early_serial.c index af5cdb3545..bbfc26430a 100644 --- a/src/superio/fintek/f71872/early_serial.c +++ b/src/superio/fintek/f71872/early_serial.c @@ -21,6 +21,7 @@ /* Pre-RAM driver for the Fintek F71872F/FG Super I/O chip. */ #include <arch/io.h> +#include <device/pnp.h> #include "f71872.h" static void pnp_enter_conf_state(device_t dev) @@ -36,7 +37,7 @@ static void pnp_exit_conf_state(device_t dev) outb(0xaa, port); } -static void f71872_enable_serial(device_t dev, u16 iobase) +void f71872_enable_serial(device_t dev, u16 iobase) { pnp_enter_conf_state(dev); pnp_set_logical_device(dev); diff --git a/src/superio/fintek/f71872/f71872.h b/src/superio/fintek/f71872/f71872.h index 585b142ab4..577f8d11d9 100644 --- a/src/superio/fintek/f71872/f71872.h +++ b/src/superio/fintek/f71872/f71872.h @@ -32,4 +32,6 @@ #define F71872_VID 0x07 /* VID */ #define F71872_PM 0x0a /* ACPI/PME */ -#endif +void f71872_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_FINTEK_F71872_F71872_H */ |