diff options
| author | Marshall Dawson <marshalldawson3rd@gmail.com> | 2017-09-22 15:35:32 -0600 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-10-02 22:26:50 +0000 |
| commit | 9db0a2dcc8925d1680a5bf223c589ff2db9eca28 (patch) | |
| tree | ab216f56ec972d7fe3e06a4d3505fe4f58faea50 | |
| parent | 714c087788b5f3dcd3bfe1f15bcef6c08d4a68db (diff) | |
| download | coreboot-9db0a2dcc8925d1680a5bf223c589ff2db9eca28.tar.xz | |
amd/stoneyridge: Clean up smi_util.c
Replace hardcoded values with defined ones.
Change-Id: If963a817a4bea9b6dbb0d41a2bc0789a44a01391
Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-on: https://review.coreboot.org/21743
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Marc Jones <marc@marcjonesconsulting.com>
| -rw-r--r-- | src/soc/amd/stoneyridge/smi_util.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/soc/amd/stoneyridge/smi_util.c b/src/soc/amd/stoneyridge/smi_util.c index 822738ca27..68e792c710 100644 --- a/src/soc/amd/stoneyridge/smi_util.c +++ b/src/soc/amd/stoneyridge/smi_util.c @@ -8,15 +8,12 @@ #include <console/console.h> #include <soc/smi.h> -#define STONEYRIDGE_SMI_ACPI_COMMAND 75 - static void configure_smi(uint8_t smi_num, uint8_t mode) { uint8_t reg32_offset, bit_offset; uint32_t reg32; - /* SMI sources range from [0:149] */ - if (smi_num > 149) { + if (smi_num >= NUMBER_SMITYPES) { printk(BIOS_WARNING, "BUG: Invalid SMI: %u\n", smi_num); return; } @@ -74,5 +71,5 @@ void disable_gevent_smi(uint8_t gevent) /** Enable SMIs on writes to ACPI SMI command port */ void enable_acpi_cmd_smi(void) { - configure_smi(STONEYRIDGE_SMI_ACPI_COMMAND, SMI_MODE_SMI); + configure_smi(SMITYPE_SMI_CMD_PORT, SMI_MODE_SMI); } |