summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTim Chu <Tim.Chu@quantatw.com>2020-11-12 03:15:39 -0800
committerPatrick Georgi <pgeorgi@google.com>2020-11-25 09:18:04 +0000
commita96eaf870015d65eff3120d4e877febb6862088b (patch)
tree8bf2e1bb54970c569e0372ab3e7b7168c14f60b9
parentf7cdb8e3c6e7c59bb80497887d15c70e2b059804 (diff)
downloadcoreboot-a96eaf870015d65eff3120d4e877febb6862088b.tar.xz
arch/x86/smbios: Update SMBIOS type 16 error correction type
Add weak function for SMBIOS type 16 error correction type. Tested=Execute "dmidecode -t 16" to check if error correction type is correct. Signed-off-by: Tim Chu <Tim.Chu@quantatw.com> Change-Id: I85b37e9cfd22a78544d03e5506ff92b1f2404f8e Reviewed-on: https://review.coreboot.org/c/coreboot/+/47508 Reviewed-by: Patrick Georgi <pgeorgi@google.com> Reviewed-by: Jonathan Zhang <jonzhang@fb.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/arch/x86/smbios.c9
-rw-r--r--src/include/smbios.h1
2 files changed, 8 insertions, 2 deletions
diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c
index da77284d37..aabeb1046c 100644
--- a/src/arch/x86/smbios.c
+++ b/src/arch/x86/smbios.c
@@ -463,6 +463,12 @@ static int get_socket_type(void)
return 0x02; /* Unknown */
}
+unsigned int __weak smbios_memory_error_correction_type(struct memory_info *meminfo)
+{
+ return meminfo->ecc_capable ?
+ MEMORY_ARRAY_ECC_SINGLE_BIT : MEMORY_ARRAY_ECC_NONE;
+}
+
unsigned int __weak smbios_processor_external_clock(void)
{
return 0; /* Unknown */
@@ -1035,8 +1041,7 @@ static int smbios_write_type16(unsigned long *current, int *handle)
t->location = MEMORY_ARRAY_LOCATION_SYSTEM_BOARD;
t->use = MEMORY_ARRAY_USE_SYSTEM;
- t->memory_error_correction = meminfo->ecc_capable ?
- MEMORY_ARRAY_ECC_SINGLE_BIT : MEMORY_ARRAY_ECC_NONE;
+ t->memory_error_correction = smbios_memory_error_correction_type(meminfo);
/* no error information handle available */
t->memory_error_information_handle = 0xFFFE;
diff --git a/src/include/smbios.h b/src/include/smbios.h
index 4ddf4384dc..e451d17ef8 100644
--- a/src/include/smbios.h
+++ b/src/include/smbios.h
@@ -57,6 +57,7 @@ const char *smbios_processor_serial_number(void);
void smbios_ec_revision(uint8_t *ec_major_revision, uint8_t *ec_minor_revision);
+unsigned int smbios_memory_error_correction_type(struct memory_info *meminfo);
unsigned int smbios_processor_external_clock(void);
unsigned int smbios_processor_characteristics(void);
struct cpuid_result;