diff options
| author | Nico Huber <nico.huber@secunet.com> | 2017-03-31 12:09:58 +0200 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2017-06-06 17:19:45 +0200 |
| commit | ac826c8fd7b616f8b65a268e7474d8c0cf84f93f (patch) | |
| tree | a23e85261abf9997d1e40331635759906f46a640 | |
| parent | a2cf686396e3a6a0b5ff544aaa70c652cd75da4e (diff) | |
| download | coreboot-ac826c8fd7b616f8b65a268e7474d8c0cf84f93f.tar.xz | |
inteltool: Don't use PCI_FILL_SIZES
This is supposed to fill the `size[]` array with the actual sizes of
a device' MMIO ranges, but apparently isn't implemented for every
access method in libpci (we let the library choose one). It tells us
by clearing `PCI_FILL_SIZES` in the return value of `pci_fill_info()`
(which we don't check). Since we don't ever use `size`, we can just
make it clear and don't ask for it.
Change-Id: I3fb9334472f1c7563a9e17910190f73affbe067a
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/19582
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
| -rw-r--r-- | util/inteltool/inteltool.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index a4814f8577..cefce7e27e 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -425,7 +425,7 @@ int main(int argc, char *argv[]) exit(1); } - pci_fill_info(sb, PCI_FILL_IDENT|PCI_FILL_BASES|PCI_FILL_SIZES|PCI_FILL_CLASS); + pci_fill_info(sb, PCI_FILL_IDENT | PCI_FILL_BASES | PCI_FILL_CLASS); if (sb->vendor_id != PCI_VENDOR_ID_INTEL) { printf("Not an Intel(R) southbridge.\n"); @@ -438,7 +438,7 @@ int main(int argc, char *argv[]) exit(1); } - pci_fill_info(nb, PCI_FILL_IDENT|PCI_FILL_BASES|PCI_FILL_SIZES|PCI_FILL_CLASS); + pci_fill_info(nb, PCI_FILL_IDENT | PCI_FILL_BASES | PCI_FILL_CLASS); if (nb->vendor_id != PCI_VENDOR_ID_INTEL) { printf("Not an Intel(R) northbridge.\n"); @@ -448,7 +448,8 @@ int main(int argc, char *argv[]) gfx = pci_get_dev(pacc, 0, 0, 0x02, 0); if (gfx) { - pci_fill_info(gfx, PCI_FILL_IDENT|PCI_FILL_BASES|PCI_FILL_SIZES|PCI_FILL_CLASS); + pci_fill_info(gfx, PCI_FILL_IDENT | PCI_FILL_BASES | + PCI_FILL_CLASS); if (gfx->vendor_id != PCI_VENDOR_ID_INTEL) gfx = 0; @@ -460,7 +461,8 @@ int main(int argc, char *argv[]) ahci = pci_get_dev(pacc, 0, 0, 0x1f, 2); if (ahci) { - pci_fill_info(ahci, PCI_FILL_IDENT|PCI_FILL_BASES|PCI_FILL_SIZES|PCI_FILL_CLASS); + pci_fill_info(ahci, PCI_FILL_IDENT | PCI_FILL_BASES | + PCI_FILL_CLASS); if (ahci->vendor_id != PCI_VENDOR_ID_INTEL) ahci = 0; |