diff options
| author | Duncan Laurie <dlaurie@google.com> | 2018-11-15 15:21:48 -0700 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2018-11-17 07:26:49 +0000 |
| commit | bf2710e8496327a9e9a1f5b4517ae2676ba78612 (patch) | |
| tree | 756c83335a78134cd8ba9a924068896206176976 | |
| parent | 79152f3c811879cc61576b7d8788d7bdda17066d (diff) | |
| download | coreboot-bf2710e8496327a9e9a1f5b4517ae2676ba78612.tar.xz | |
mb/google/sarien: Set SMBIOS mainboard SKU
Setting sku_id() is not enough to get a value to show up in the SMBIOS
tables, it also needs to be returned as a string for the table creation
to consume. This change defines the smbios_mainboard_sku() function
and returns a string constant of "sku#" as expected.
Change-Id: I03013bab89d53d1eba969c6ffb7e95fcbb315a81
Signed-off-by: Duncan Laurie <dlaurie@google.com>
Reviewed-on: https://review.coreboot.org/29649
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Trent Begin <tbegin@google.com>
3 files changed, 8 insertions, 0 deletions
diff --git a/src/mainboard/google/sarien/sku.c b/src/mainboard/google/sarien/sku.c index 9fc61a3316..c064c02ef7 100644 --- a/src/mainboard/google/sarien/sku.c +++ b/src/mainboard/google/sarien/sku.c @@ -14,9 +14,15 @@ */ #include <boardid.h> +#include <smbios.h> #include <variant/variant.h> uint32_t sku_id(void) { return VARIANT_SKU_ID; } + +const char *smbios_mainboard_sku(void) +{ + return VARIANT_SKU_NAME; +} diff --git a/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h b/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h index f1e551a505..d1284322bb 100644 --- a/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h +++ b/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h @@ -18,5 +18,6 @@ /* Arcada is SKU ID 2 */ #define VARIANT_SKU_ID 2 +#define VARIANT_SKU_NAME "sku2" #endif diff --git a/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h b/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h index d0be7fcf22..d36750571a 100644 --- a/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h +++ b/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h @@ -18,5 +18,6 @@ /* Sarien is SKU ID 1 */ #define VARIANT_SKU_ID 1 +#define VARIANT_SKU_NAME "sku1" #endif |