diff options
| author | Daniel Kurtz <djkurtz@chromium.org> | 2018-07-23 17:26:59 -0600 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2018-07-30 18:45:44 +0000 |
| commit | cd62cac9e1f76d4086dc757701ad724a79654b1b (patch) | |
| tree | eb59635226f0dd711ec973cd7700b480506152eb | |
| parent | 791ba97d1d1f5923303f159ac0da154e082a12f2 (diff) | |
| download | coreboot-cd62cac9e1f76d4086dc757701ad724a79654b1b.tar.xz | |
drivers/i2c/da7219: Allow disabling micbias-pulse feature
These two da7219_aad properties are optional:
- dlg,micbias-pulse-lvl : Mic bias higher voltage pulse level (mV).
[<2800>, <2900>]
- dlg,micbias-pulse-time : Mic bias higher voltage pulse duration (ms)
When the Mic Bias Higher Voltage feature is not required, firmware should
just not provide the dlg,micbias-pulse-lvl and dlg,micbias-pulse-time
properties.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
BUG=b:111700809
TEST=On grunt:
No "Invalid micbias pulse level" in dmesg
Change-Id: Ie99a8962e78c68b3f6927d0de34168f265d4efa9
Reviewed-on: https://review.coreboot.org/27613
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Akshu Agrawal <akshu.agrawal@amd.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/drivers/i2c/da7219/da7219.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/drivers/i2c/da7219/da7219.c b/src/drivers/i2c/da7219/da7219.c index b8af689312..43e6076b73 100644 --- a/src/drivers/i2c/da7219/da7219.c +++ b/src/drivers/i2c/da7219/da7219.c @@ -77,10 +77,12 @@ static void da7219_fill_ssdt(struct device *dev) acpi_dp_add_integer(aad, "dlg,c-mic-btn-thr", config->c_mic_btn_thr); acpi_dp_add_integer(aad, "dlg,btn-avg", config->btn_avg); acpi_dp_add_integer(aad, "dlg,adc-1bit-rpt", config->adc_1bit_rpt); - acpi_dp_add_integer(aad, "dlg,micbias-pulse-lvl", - config->micbias_pulse_lvl); - acpi_dp_add_integer(aad, "dlg,micbias-pulse-time", - config->micbias_pulse_time); + if (config->micbias_pulse_lvl > 0) { + acpi_dp_add_integer(aad, "dlg,micbias-pulse-lvl", + config->micbias_pulse_lvl); + acpi_dp_add_integer(aad, "dlg,micbias-pulse-time", + config->micbias_pulse_time); + } /* DA7219 Properties */ dsd = acpi_dp_new_table("_DSD"); |