summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Georgi <patrick.georgi@secunet.com>2012-05-18 12:47:02 +0200
committerStefan Reinauer <stefan.reinauer@coreboot.org>2012-11-06 21:53:48 +0100
commitd635068ffaf97d5d94f3e2b2ccee409ed44b0b41 (patch)
tree25e0d992b0e16f49b062f6d27e3040fe4d7f4d99
parent68d7c7aa8ba8a8bc17b3cebf1b7086cf8a4fa94d (diff)
downloadcoreboot-d635068ffaf97d5d94f3e2b2ccee409ed44b0b41.tar.xz
smsc/lpc47n227: Make early_serial usable
This is the smallest possible change to make early_serial.c compile when included from romstage.c. early_serial could be reworked to be built as separate unit (romstage-y), but that should be done for all SuperIOs, not some individual outlier. Change-Id: I90ee66b43c9677b86b1b5d6fcc8febfbe58d80dd Signed-off-by: Patrick Georgi <patrick.georgi@secunet.com> Reviewed-on: http://review.coreboot.org/1686 Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
-rw-r--r--src/superio/smsc/lpc47n227/early_serial.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/superio/smsc/lpc47n227/early_serial.c b/src/superio/smsc/lpc47n227/early_serial.c
index 32bd3e3680..a60dc48a95 100644
--- a/src/superio/smsc/lpc47n227/early_serial.c
+++ b/src/superio/smsc/lpc47n227/early_serial.c
@@ -41,10 +41,13 @@ static void pnp_exit_conf_state(device_t dev)
* @param dev High 8 bits = Super I/O port, low 8 bits = logical device number.
* @param iobase Base I/O port for the logical device.
*/
-void lpc47n227_pnp_set_iobase(device_t dev, u16 iobase)
+static void lpc47n227_pnp_set_iobase(device_t dev, u16 iobase)
{
/* LPC47N227 requires base ports to be a multiple of 4. */
+ /* it's not very useful to do an ASSERT here: if it trips,
+ * there's no console to report it.
ASSERT(!(iobase & 0x3));
+ */
switch (dev & 0xFF) {
case LPC47N227_PP:
@@ -73,7 +76,7 @@ void lpc47n227_pnp_set_iobase(device_t dev, u16 iobase)
* @param dev High 8 bits = Super I/O port, low 8 bits = logical device number.
* @param enable 0 to disable, anythig else to enable.
*/
-void lpc47n227_pnp_set_enable(device_t dev, int enable)
+static void lpc47n227_pnp_set_enable(device_t dev, int enable)
{
u8 power_register = 0, power_mask = 0, current_power, new_power;