summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEdward O'Callaghan <eocallaghan@alterapraxis.com>2014-11-07 12:43:49 +1100
committerEdward O'Callaghan <eocallaghan@alterapraxis.com>2014-11-07 12:50:22 +0100
commit0d84a2c03e9c3a65ddc3de173dc0c1045049c3dd (patch)
tree67116e8ddcccb91fde30748655b100f05238802f
parent2014111786cbbac34535844356c2655529bc28ae (diff)
downloadcoreboot-0d84a2c03e9c3a65ddc3de173dc0c1045049c3dd.tar.xz
drivers/ioapic: DEVICE_NOOP some stub function callbacks
Just when you thought you found them all.. Reduces loc and makes NOP's explicit. Change-Id: I416e0468b7f2f462c940daae695d67fb409aa4c6 Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Reviewed-on: http://review.coreboot.org/7350 Tested-by: build bot (Jenkins) Reviewed-by: Marc Jones <marc.jones@se-eng.com>
-rw-r--r--src/drivers/generic/ioapic/ioapic.c17
1 files changed, 5 insertions, 12 deletions
diff --git a/src/drivers/generic/ioapic/ioapic.c b/src/drivers/generic/ioapic/ioapic.c
index 9c4bc7d6ce..463474a30d 100644
--- a/src/drivers/generic/ioapic/ioapic.c
+++ b/src/drivers/generic/ioapic/ioapic.c
@@ -20,6 +20,7 @@ static void ioapic_init(struct device *dev)
u32 i, ioapic_interrupts;
u32 ioapic_base;
u8 ioapic_id;
+
if (!dev->enabled || !config)
return;
@@ -86,14 +87,6 @@ static void ioapic_init(struct device *dev)
}
}
-static void ioapic_enable_resources(struct device *dev)
-{
-}
-
-static void ioapic_nop(struct device *dummy)
-{
-}
-
static void ioapic_read_resources(struct device *dev)
{
struct drivers_generic_ioapic_config *config = (struct drivers_generic_ioapic_config *)dev->chip_info;
@@ -106,10 +99,10 @@ static void ioapic_read_resources(struct device *dev)
}
static struct device_operations ioapic_operations = {
- .read_resources = ioapic_read_resources,
- .set_resources = ioapic_nop,
- .enable_resources = ioapic_enable_resources,
- .init = ioapic_init,
+ .read_resources = ioapic_read_resources,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
+ .init = ioapic_init,
};
static void enable_dev(struct device *dev)