summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Roth <martinroth@google.com>2015-11-23 16:14:13 -0700
committerMartin Roth <martinroth@google.com>2015-11-27 18:07:09 +0100
commit232df8b2d232f481576737de952c6168d4d00874 (patch)
treeefa981fdabdc5b3738e1bdc6725acb165c849b92
parentd38b22f8ec547296e569964279362f13c1ee598c (diff)
downloadcoreboot-232df8b2d232f481576737de952c6168d4d00874.tar.xz
kontron/986lcd-m: Fix IASL warning and remark
- Add an empty Operating Region for the empty _REG method - Serialize _CRS Method - Remove Kconfig default disabling IASL warnings as errors Fixes IASL Warning and remark: dsdt.aml 1451: Method (_CRS, 0) Remark 2120 - ^ Control Method should be made Serialized (due to creation of named objects within) dsdt.aml 1460: Method (_REG, 2) Warning 3079 - ^ _REG has no corresponding Operation Region Change-Id: I4aa59468a89c4013146ab34004476a0968c60707 Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: https://review.coreboot.org/12521 Reviewed-by: Patrick Georgi <pgeorgi@google.com> Tested-by: build bot (Jenkins)
-rw-r--r--src/mainboard/kontron/986lcd-m/Kconfig4
-rw-r--r--src/mainboard/kontron/986lcd-m/acpi/ec.asl8
2 files changed, 7 insertions, 5 deletions
diff --git a/src/mainboard/kontron/986lcd-m/Kconfig b/src/mainboard/kontron/986lcd-m/Kconfig
index a589b461b2..2a3cfe2e14 100644
--- a/src/mainboard/kontron/986lcd-m/Kconfig
+++ b/src/mainboard/kontron/986lcd-m/Kconfig
@@ -42,8 +42,4 @@ config VGA_BIOS_FILE
string
default "amipci_01.20"
-# TODO: Remove this when platform ASL is fixed
-config IASL_WARNINGS_ARE_ERRORS
- def_bool n
-
endif # BOARD_KONTRON_986LCD_M
diff --git a/src/mainboard/kontron/986lcd-m/acpi/ec.asl b/src/mainboard/kontron/986lcd-m/acpi/ec.asl
index 4decb5d798..5b3a2318b1 100644
--- a/src/mainboard/kontron/986lcd-m/acpi/ec.asl
+++ b/src/mainboard/kontron/986lcd-m/acpi/ec.asl
@@ -18,7 +18,13 @@ Device(EC0)
Name (_HID, EISAID("PNP0C09"))
Name (_UID, 1)
- Method (_CRS, 0)
+ // _REG method requires that an operation region is defined.
+ OperationRegion (ERAM, EmbeddedControl, 0x00, 0xff)
+ Field (ERAM, ByteAcc, Lock, Preserve)
+ {
+ }
+
+ Method (_CRS, 0, Serialized)
{
Name (ECMD, ResourceTemplate()
{