summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Hendricks <dhendrix@chromium.org>2013-02-13 20:00:49 -0800
committerRonald G. Minnich <rminnich@gmail.com>2013-02-14 07:05:04 +0100
commit398e84c71a15b7db8c631bb5b17d1a1a60c91128 (patch)
tree3eeddc6e9d1093329660836bc1ae38cc7aeac782
parenta86e4ba8bdc7fd45ab76697d32d4e95cf3116700 (diff)
downloadcoreboot-398e84c71a15b7db8c631bb5b17d1a1a60c91128.tar.xz
armv7: don't write a forward entry in coreboot tables
We don't seem to need it, and it currently confuses the payload. (credit to Gabe Black for this, I'm just uploading it) Change-Id: I4e3a60eceb9b24e3bc8e50db431c1a731d1cdbae Signed-off-by: David Hendricks <dhendrix@chromium.org> Signed-off-by: Gabe Black <gabeblack@chromium.org> Reviewed-on: http://review.coreboot.org/2385 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
-rw-r--r--src/arch/armv7/boot/coreboot_table.c18
1 files changed, 0 insertions, 18 deletions
diff --git a/src/arch/armv7/boot/coreboot_table.c b/src/arch/armv7/boot/coreboot_table.c
index ed105a4fc9..64f6a664e7 100644
--- a/src/arch/armv7/boot/coreboot_table.c
+++ b/src/arch/armv7/boot/coreboot_table.c
@@ -329,20 +329,6 @@ static void lb_strings(struct lb_header *header)
}
-#if CONFIG_WRITE_HIGH_TABLES
-static struct lb_forward *lb_forward(struct lb_header *header, struct lb_header *next_header)
-{
- struct lb_record *rec;
- struct lb_forward *forward;
- rec = lb_new_record(header);
- forward = (struct lb_forward *)rec;
- forward->tag = LB_TAG_FORWARD;
- forward->size = sizeof(*forward);
- forward->forward = (uint64_t)(unsigned long)next_header;
- return forward;
-}
-#endif
-
/* FIXME(dhendrix): used to be static void lb_memory_range(), but compiler
started complaining since it shares a name with a non-static struct. ugh. */
static void new_lb_memory_range(struct lb_memory *mem,
@@ -612,10 +598,6 @@ unsigned long write_coreboot_table(
table_start, table_end);
head = lb_table_init(table_start);
- printk(BIOS_DEBUG, "Writing table forward entry at 0x%08lx\n",
- table_end);
- lb_forward(head, (struct lb_header*)table_end);
-
table_end = (unsigned long) head + head->table_bytes;
/* FIXME(dhendrix): do we need this? */