summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Rudolph <patrick.rudolph@9elements.com>2018-12-21 11:14:31 +0100
committerPatrick Georgi <pgeorgi@google.com>2018-12-24 08:14:54 +0000
commit3f4ed7a40b8bfecaf4064356774036d43dd06d42 (patch)
treed845cb56bbac826a3ff7f55bced58f17ce41a1f0
parent56db59c91a52995de4ef2bd73da6a69cd94a3ee3 (diff)
downloadcoreboot-3f4ed7a40b8bfecaf4064356774036d43dd06d42.tar.xz
soc/intel/fsp_broadwell_de/acpi: Fix wrong table checksum
Fix the following warning shown in dmesg: "ACPI BIOS Warning (bug): Incorrect checksum in table [FACP]" The table checksum was wrong as it was calculated twice and with the second time the checksum field wasn't set to zero. Change-Id: I375354bf3e95ebdac3b0dad43659d72c6ab3175a Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> Reviewed-on: https://review.coreboot.org/c/30353 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Jay Talbott <JayTalbott@sysproconsulting.com> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
-rw-r--r--src/soc/intel/fsp_broadwell_de/acpi.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/soc/intel/fsp_broadwell_de/acpi.c b/src/soc/intel/fsp_broadwell_de/acpi.c
index d5bee64a24..ad88313ade 100644
--- a/src/soc/intel/fsp_broadwell_de/acpi.c
+++ b/src/soc/intel/fsp_broadwell_de/acpi.c
@@ -307,8 +307,6 @@ void acpi_fill_in_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
fadt->x_gpe1_blk.access_size = 0;
fadt->x_gpe1_blk.addrl = fadt->gpe1_blk;
fadt->x_gpe1_blk.addrh = 0x00;
-
- header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t));
}
static unsigned long acpi_fill_dmar(unsigned long current)