summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEdward O'Callaghan <eocallaghan@alterapraxis.com>2014-10-31 07:55:45 +1100
committerEdward O'Callaghan <eocallaghan@alterapraxis.com>2014-11-01 21:14:07 +0100
commit524625d4e0a6ee07b01960437a3f918c0f04a1bb (patch)
treebf058469e001129a0d1dc91983b494a6ba3c66a7
parent530355d41bf10fa4f0ee215e0e71fc68e80053ea (diff)
downloadcoreboot-524625d4e0a6ee07b01960437a3f918c0f04a1bb.tar.xz
drivers: Use DEVICE_NOOP macro over dummy symbol
Change-Id: I931bd9c89bce6ac8f8e9e482a7876e2004abfb38 Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Reviewed-on: http://review.coreboot.org/7284 Tested-by: build bot (Jenkins) Reviewed-by: Bruce Griffith <Bruce.Griffith@se-eng.com>
-rw-r--r--src/drivers/i2c/adm1026/adm1026.c10
-rw-r--r--src/drivers/i2c/adm1027/adm1027.c10
-rw-r--r--src/drivers/i2c/adt7463/adt7463.c10
-rw-r--r--src/drivers/i2c/at24rf08c/at24rf08c.c10
-rw-r--r--src/drivers/i2c/i2cmux/i2cmux.c12
-rw-r--r--src/drivers/i2c/i2cmux2/i2cmux2.c12
-rw-r--r--src/drivers/i2c/lm63/lm63.c10
-rw-r--r--src/drivers/i2c/rtd2132/rtd2132.c10
-rw-r--r--src/drivers/i2c/w83793/w83793.c10
-rw-r--r--src/drivers/i2c/w83795/w83795.c10
-rw-r--r--src/drivers/ics/954309/ics954309.c10
11 files changed, 35 insertions, 79 deletions
diff --git a/src/drivers/i2c/adm1026/adm1026.c b/src/drivers/i2c/adm1026/adm1026.c
index e8baea1c40..592916afbd 100644
--- a/src/drivers/i2c/adm1026/adm1026.c
+++ b/src/drivers/i2c/adm1026/adm1026.c
@@ -44,14 +44,10 @@ static void adm1026_init(struct device *dev)
}
}
-static void adm1026_noop(struct device *dummy)
-{
-}
-
static struct device_operations adm1026_operations = {
- .read_resources = adm1026_noop,
- .set_resources = adm1026_noop,
- .enable_resources = adm1026_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
.init = adm1026_init,
};
diff --git a/src/drivers/i2c/adm1027/adm1027.c b/src/drivers/i2c/adm1027/adm1027.c
index 9841c81954..4e67e4d5f5 100644
--- a/src/drivers/i2c/adm1027/adm1027.c
+++ b/src/drivers/i2c/adm1027/adm1027.c
@@ -50,14 +50,10 @@ static void adm1027_init(struct device *dev)
}
}
-static void adm1027_noop(struct device *dummy)
-{
-}
-
static struct device_operations adm1027_operations = {
- .read_resources = adm1027_noop,
- .set_resources = adm1027_noop,
- .enable_resources = adm1027_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
.init = adm1027_init,
};
diff --git a/src/drivers/i2c/adt7463/adt7463.c b/src/drivers/i2c/adt7463/adt7463.c
index dd6d8372c3..2fb42a9773 100644
--- a/src/drivers/i2c/adt7463/adt7463.c
+++ b/src/drivers/i2c/adt7463/adt7463.c
@@ -85,14 +85,10 @@ static void adt7463_init(struct device *adt7463)
printk(BIOS_DEBUG, "ADT7463 properly initialized\n");
}
-static void adt7463_noop(struct device *dummy)
-{
-}
-
static struct device_operations adt7463_operations = {
- .read_resources = adt7463_noop,
- .set_resources = adt7463_noop,
- .enable_resources = adt7463_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
.init = adt7463_init,
};
diff --git a/src/drivers/i2c/at24rf08c/at24rf08c.c b/src/drivers/i2c/at24rf08c/at24rf08c.c
index a03564f8db..a9b821afa8 100644
--- a/src/drivers/i2c/at24rf08c/at24rf08c.c
+++ b/src/drivers/i2c/at24rf08c/at24rf08c.c
@@ -52,14 +52,10 @@ static void at24rf08c_init(struct device *dev)
printk (BIOS_DEBUG, "init EEPROM done\n");
}
-static void at24rf08c_noop(struct device *dummy)
-{
-}
-
static struct device_operations at24rf08c_operations = {
- .read_resources = at24rf08c_noop,
- .set_resources = at24rf08c_noop,
- .enable_resources = at24rf08c_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
.init = at24rf08c_init,
};
diff --git a/src/drivers/i2c/i2cmux/i2cmux.c b/src/drivers/i2c/i2cmux/i2cmux.c
index d8ad40b691..1091653f11 100644
--- a/src/drivers/i2c/i2cmux/i2cmux.c
+++ b/src/drivers/i2c/i2cmux/i2cmux.c
@@ -16,15 +16,11 @@ static void i2cmux_set_link(struct device *dev, unsigned int link)
}
}
-static void i2cmux_noop(struct device *dummy)
-{
-}
-
static struct device_operations i2cmux_operations = {
- .read_resources = i2cmux_noop,
- .set_resources = i2cmux_noop,
- .enable_resources = i2cmux_noop,
- .init = i2cmux_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
+ .init = DEVICE_NOOP,
.scan_bus = scan_static_bus,
.set_link = i2cmux_set_link,
};
diff --git a/src/drivers/i2c/i2cmux2/i2cmux2.c b/src/drivers/i2c/i2cmux2/i2cmux2.c
index 6b05508a1b..fe48e76b69 100644
--- a/src/drivers/i2c/i2cmux2/i2cmux2.c
+++ b/src/drivers/i2c/i2cmux2/i2cmux2.c
@@ -15,15 +15,11 @@ static void i2cmux2_set_link(struct device *dev, unsigned int link)
}
}
-static void i2cmux2_noop(struct device *dummy)
-{
-}
-
static struct device_operations i2cmux2_operations = {
- .read_resources = i2cmux2_noop,
- .set_resources = i2cmux2_noop,
- .enable_resources = i2cmux2_noop,
- .init = i2cmux2_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
+ .init = DEVICE_NOOP,
.scan_bus = scan_static_bus,
.set_link = i2cmux2_set_link,
};
diff --git a/src/drivers/i2c/lm63/lm63.c b/src/drivers/i2c/lm63/lm63.c
index b64751e300..3ce5fd8862 100644
--- a/src/drivers/i2c/lm63/lm63.c
+++ b/src/drivers/i2c/lm63/lm63.c
@@ -21,14 +21,10 @@ static void lm63_init(struct device *dev)
}
}
-static void lm63_noop(struct device *dummy)
-{
-}
-
static struct device_operations lm63_operations = {
- .read_resources = lm63_noop,
- .set_resources = lm63_noop,
- .enable_resources = lm63_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
.init = lm63_init,
};
diff --git a/src/drivers/i2c/rtd2132/rtd2132.c b/src/drivers/i2c/rtd2132/rtd2132.c
index 4dbfb41890..7bb21467e0 100644
--- a/src/drivers/i2c/rtd2132/rtd2132.c
+++ b/src/drivers/i2c/rtd2132/rtd2132.c
@@ -241,14 +241,10 @@ static void rtd2132_init(struct device *dev)
}
}
-static void rtd2132_noop(struct device *dummy)
-{
-}
-
static struct device_operations rtd2132_operations = {
- .read_resources = rtd2132_noop,
- .set_resources = rtd2132_noop,
- .enable_resources = rtd2132_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
.init = rtd2132_init,
};
diff --git a/src/drivers/i2c/w83793/w83793.c b/src/drivers/i2c/w83793/w83793.c
index 732fdb4c6d..4b947d76bb 100644
--- a/src/drivers/i2c/w83793/w83793.c
+++ b/src/drivers/i2c/w83793/w83793.c
@@ -220,14 +220,10 @@ static void w83793_init(struct device *dev)
}
-static void w83793_noop(struct device *dummy)
-{
-}
-
static struct device_operations w83793_operations = {
- .read_resources = w83793_noop,
- .set_resources = w83793_noop,
- .enable_resources = w83793_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
.init = w83793_init,
};
diff --git a/src/drivers/i2c/w83795/w83795.c b/src/drivers/i2c/w83795/w83795.c
index 5559666f9a..569fe5ac3c 100644
--- a/src/drivers/i2c/w83795/w83795.c
+++ b/src/drivers/i2c/w83795/w83795.c
@@ -239,14 +239,10 @@ static void w83795_hwm_init(struct device *dev)
printk(BIOS_ERR, "Neither AMD nor INTEL CPU detected\n");
}
-static void w83795_noop(struct device *dummy)
-{
-}
-
static struct device_operations w83795_operations = {
- .read_resources = w83795_noop,
- .set_resources = w83795_noop,
- .enable_resources = w83795_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
.init = w83795_hwm_init,
};
diff --git a/src/drivers/ics/954309/ics954309.c b/src/drivers/ics/954309/ics954309.c
index 0aa15c059e..fda37afcdb 100644
--- a/src/drivers/ics/954309/ics954309.c
+++ b/src/drivers/ics/954309/ics954309.c
@@ -55,14 +55,10 @@ static void ics954309_init(struct device *dev)
smbus_block_write(dev, 0, 12, initdata);
}
-static void ics954309_noop(struct device *dummy)
-{
-}
-
static struct device_operations ics954309_operations = {
- .read_resources = ics954309_noop,
- .set_resources = ics954309_noop,
- .enable_resources = ics954309_noop,
+ .read_resources = DEVICE_NOOP,
+ .set_resources = DEVICE_NOOP,
+ .enable_resources = DEVICE_NOOP,
.init = ics954309_init,
};