summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2020-06-02 12:53:09 +0300
committerFelix Held <felix-coreboot@felixheld.de>2020-06-10 01:08:24 +0000
commit55c0c4bc869ae0246883d1d43ffc47a48fa90377 (patch)
treec1eeafed2c58c3ac1960f156cacf34a11526b795
parent4a09b97cad5f5658fdac3119062ce42704388507 (diff)
downloadcoreboot-55c0c4bc869ae0246883d1d43ffc47a48fa90377.tar.xz
mb,sb/amd/cimx/sb800: Remove FADT_PM_PROFILE
The platform_cfg.h files under mainboard/ are a legacy configuration mechanism used with AGESA family14 boards. With this change following boards will have FADT preferred_pm_profile changed from PM_UNSPECIFIED to PM_DESKTOP: amd/inaqua amd/south_station amd/union_station asrock/e350m1 Change-Id: Ic28761eb238dbbaf3e8f820a29ec64b89f12bf53 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/42031 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
-rw-r--r--src/mainboard/amd/persimmon/platform_cfg.h14
-rw-r--r--src/mainboard/elmex/pcm205400/platform_cfg.h14
-rw-r--r--src/mainboard/gizmosphere/gizmo/platform_cfg.h14
-rw-r--r--src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h14
-rw-r--r--src/mainboard/lippert/frontrunner-af/platform_cfg.h14
-rw-r--r--src/mainboard/lippert/toucan-af/platform_cfg.h14
-rw-r--r--src/mainboard/pcengines/apu1/platform_cfg.h14
-rw-r--r--src/southbridge/amd/cimx/sb800/fadt.c6
8 files changed, 1 insertions, 103 deletions
diff --git a/src/mainboard/amd/persimmon/platform_cfg.h b/src/mainboard/amd/persimmon/platform_cfg.h
index e93c306750..87a5cc48a0 100644
--- a/src/mainboard/amd/persimmon/platform_cfg.h
+++ b/src/mainboard/amd/persimmon/platform_cfg.h
@@ -224,18 +224,4 @@ static const CODECTBLLIST codec_tablelist[] =
*/
#define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */
-/* from acpi.h
- * PM_UNSPECIFIED = 0,
- * PM_DESKTOP = 1,
- * PM_MOBILE = 2,
- * PM_WORKSTATION = 3,
- * PM_ENTERPRISE_SERVER = 4,
- * PM_SOHO_SERVER = 5,
- * PM_APPLIANCE_PC = 6,
- * PM_PERFORMANCE_SERVER = 7,
- * PM_TABLET = 8
- */
-#define FADT_PM_PROFILE 1
-
#endif /* _PLATFORM_CFG_H_ */
diff --git a/src/mainboard/elmex/pcm205400/platform_cfg.h b/src/mainboard/elmex/pcm205400/platform_cfg.h
index f4a3e59d31..b621f60b81 100644
--- a/src/mainboard/elmex/pcm205400/platform_cfg.h
+++ b/src/mainboard/elmex/pcm205400/platform_cfg.h
@@ -222,18 +222,4 @@ static const CODECTBLLIST codec_tablelist[] = {
*/
//#define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */
-/* from acpi.h
- * PM_UNSPECIFIED = 0,
- * PM_DESKTOP = 1,
- * PM_MOBILE = 2,
- * PM_WORKSTATION = 3,
- * PM_ENTERPRISE_SERVER = 4,
- * PM_SOHO_SERVER = 5,
- * PM_APPLIANCE_PC = 6,
- * PM_PERFORMANCE_SERVER = 7,
- * PM_TABLET = 8
- */
-#define FADT_PM_PROFILE 1
-
#endif /* _PLATFORM_CFG_H_ */
diff --git a/src/mainboard/gizmosphere/gizmo/platform_cfg.h b/src/mainboard/gizmosphere/gizmo/platform_cfg.h
index f4f713be39..2ea529ffcc 100644
--- a/src/mainboard/gizmosphere/gizmo/platform_cfg.h
+++ b/src/mainboard/gizmosphere/gizmo/platform_cfg.h
@@ -229,18 +229,4 @@ static const CODECTBLLIST codec_tablelist[] =
*/
#define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */
-/* from acpi.h
- * PM_UNSPECIFIED = 0,
- * PM_DESKTOP = 1,
- * PM_MOBILE = 2,
- * PM_WORKSTATION = 3,
- * PM_ENTERPRISE_SERVER = 4,
- * PM_SOHO_SERVER = 5,
- * PM_APPLIANCE_PC = 6,
- * PM_PERFORMANCE_SERVER = 7,
- * PM_TABLET = 8
- */
-#define FADT_PM_PROFILE 1
-
#endif
diff --git a/src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h b/src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h
index 8bdaf7e1ed..bacb7b11aa 100644
--- a/src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h
+++ b/src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h
@@ -226,18 +226,4 @@ static const CODECTBLLIST codec_tablelist[] =
*/
#define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */
-/* from acpi.h
- * PM_UNSPECIFIED = 0,
- * PM_DESKTOP = 1,
- * PM_MOBILE = 2,
- * PM_WORKSTATION = 3,
- * PM_ENTERPRISE_SERVER = 4,
- * PM_SOHO_SERVER = 5,
- * PM_APPLIANCE_PC = 6,
- * PM_PERFORMANCE_SERVER = 7,
- * PM_TABLET = 8
- */
-#define FADT_PM_PROFILE 1
-
#endif /* _PLATFORM_CFG_H_ */
diff --git a/src/mainboard/lippert/frontrunner-af/platform_cfg.h b/src/mainboard/lippert/frontrunner-af/platform_cfg.h
index ad60ef20f2..7d4f1f944d 100644
--- a/src/mainboard/lippert/frontrunner-af/platform_cfg.h
+++ b/src/mainboard/lippert/frontrunner-af/platform_cfg.h
@@ -226,18 +226,4 @@ static const CODECTBLLIST codec_tablelist[] =
*/
#define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */
-/* from acpi.h
- * PM_UNSPECIFIED = 0,
- * PM_DESKTOP = 1,
- * PM_MOBILE = 2,
- * PM_WORKSTATION = 3,
- * PM_ENTERPRISE_SERVER = 4,
- * PM_SOHO_SERVER = 5,
- * PM_APPLIANCE_PC = 6,
- * PM_PERFORMANCE_SERVER = 7,
- * PM_TABLET = 8
- */
-#define FADT_PM_PROFILE 1
-
#endif
diff --git a/src/mainboard/lippert/toucan-af/platform_cfg.h b/src/mainboard/lippert/toucan-af/platform_cfg.h
index b57e195632..b029efb069 100644
--- a/src/mainboard/lippert/toucan-af/platform_cfg.h
+++ b/src/mainboard/lippert/toucan-af/platform_cfg.h
@@ -226,18 +226,4 @@ static const CODECTBLLIST codec_tablelist[] =
*/
#define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */
-/* from acpi.h
- * PM_UNSPECIFIED = 0,
- * PM_DESKTOP = 1,
- * PM_MOBILE = 2,
- * PM_WORKSTATION = 3,
- * PM_ENTERPRISE_SERVER = 4,
- * PM_SOHO_SERVER = 5,
- * PM_APPLIANCE_PC = 6,
- * PM_PERFORMANCE_SERVER = 7,
- * PM_TABLET = 8
- */
-#define FADT_PM_PROFILE 1
-
#endif
diff --git a/src/mainboard/pcengines/apu1/platform_cfg.h b/src/mainboard/pcengines/apu1/platform_cfg.h
index 63a3d5a7cb..6087b1504a 100644
--- a/src/mainboard/pcengines/apu1/platform_cfg.h
+++ b/src/mainboard/pcengines/apu1/platform_cfg.h
@@ -198,20 +198,6 @@
*/
#define GEC_CONFIG 0
-/* set up an ACPI preferred power management profile */
-/* from acpi.h
- * PM_UNSPECIFIED = 0,
- * PM_DESKTOP = 1,
- * PM_MOBILE = 2,
- * PM_WORKSTATION = 3,
- * PM_ENTERPRISE_SERVER = 4,
- * PM_SOHO_SERVER = 5,
- * PM_APPLIANCE_PC = 6,
- * PM_PERFORMANCE_SERVER = 7,
- * PM_TABLET = 8
- */
-#define FADT_PM_PROFILE 1
-
/**
* @def USB_RX_MODE
* 0x00 - leave Cg2Pll voltage at default value (1.222V)
diff --git a/src/southbridge/amd/cimx/sb800/fadt.c b/src/southbridge/amd/cimx/sb800/fadt.c
index d2339c6e00..153becca98 100644
--- a/src/southbridge/amd/cimx/sb800/fadt.c
+++ b/src/southbridge/amd/cimx/sb800/fadt.c
@@ -23,10 +23,6 @@
#endif
#endif
-#ifndef FADT_PM_PROFILE
- #define FADT_PM_PROFILE PM_UNSPECIFIED
-#endif
-
/*
* Reference section 5.2.9 Fixed ACPI Description Table (FADT)
* in the ACPI 3.0b specification.
@@ -59,7 +55,7 @@ void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
fadt->dsdt = (uintptr_t)dsdt;
fadt->reserved = 0; /* reserved, should be 0 ACPI 3.0 */
- fadt->preferred_pm_profile = FADT_PM_PROFILE;
+ fadt->preferred_pm_profile = PM_DESKTOP;
fadt->sci_int = 9; /* HUDSON 1 - IRQ 09 - ACPI SCI */
val = PM1_EVT_BLK_ADDRESS;