summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2017-10-09 05:29:30 +0300
committerMartin Roth <martinroth@google.com>2018-01-23 05:34:31 +0000
commit583e0522f14fde040f48d2444099e4dededfa185 (patch)
treeaf78b44e9650beb230b0d5c53fb7b35f1159f6e1
parent972d95cd7f9e02059ba3fd3b16f731094cdb51a6 (diff)
downloadcoreboot-583e0522f14fde040f48d2444099e4dededfa185.tar.xz
binaryPI vendorcode: Remove HeapXXBuffer functions
The HeapAllocateBuffer and HeapDeallocateBuffer functions are not used. Change-Id: I491a796d87afd0e37051f9caabfff3f70d4d803c Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/22069 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
-rw-r--r--src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c59
-rw-r--r--src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c60
-rw-r--r--src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c60
3 files changed, 0 insertions, 179 deletions
diff --git a/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c
index 52cf3960c7..2bc939970f 100644
--- a/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c
@@ -50,18 +50,6 @@
#include <FchDef.h>
#include <FieldAccessors.h>
-AGESA_STATUS
-HeapAllocateBuffer (
- IN OUT VOID *AllocateHeapParams,
- IN OUT VOID *StdHeader
- );
-
-AGESA_STATUS
-HeapDeallocateBuffer (
- IN UINT32 BufferHandle,
- IN VOID *StdHeader
- );
-
CONST UINT32 ImageSignature = IMAGE_SIGNATURE;
CONST UINT32 ModuleSignature = MODULE_SIGNATURE;
CONST CHAR8 ModuleIdentifier[] = AGESA_ID;
@@ -524,53 +512,6 @@ ImcIdle (
((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
}
-// TODO This has to be removed
-AGESA_STATUS
-HeapAllocateBuffer (
- IN OUT VOID *AllocateHeapParams,
- IN OUT VOID *StdHeader
- )
-{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
-
- AMD_INTERFACE_PARAMS InterfaceParams = {};
-
- if (!module) return AGESA_UNSUPPORTED;
- Dispatcher = module->ModuleDispatcher;
-
- InterfaceParams.StdHeader = *(AMD_CONFIG_PARAMS*)StdHeader;
- InterfaceParams.StdHeader.Func = AMD_HEAP_ALLOCATE_BUFFER;
-
- InterfaceParams.AllocationMethod = PreMemHeap;
- InterfaceParams.NewStructPtr = AllocateHeapParams;
-
- return Dispatcher(&InterfaceParams);
-}
-
-// TODO This has to be removed
-AGESA_STATUS
-HeapDeallocateBuffer (
- IN UINT32 BufferHandle,
- IN VOID *StdHeader
- )
-{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
-
- AMD_INTERFACE_PARAMS InterfaceParams = {};
-
- if (!module) return AGESA_UNSUPPORTED;
- Dispatcher = module->ModuleDispatcher;
-
- InterfaceParams.StdHeader = *(AMD_CONFIG_PARAMS*)StdHeader;
- InterfaceParams.StdHeader.Func = AMD_HEAP_DEALLOCATE_BUFFER;
-
- InterfaceParams.NewStructPtr = &BufferHandle;
-
- return Dispatcher(&InterfaceParams);
-}
-
/**********************************************************************
* Interface call: AmdSetValue
**********************************************************************/
diff --git a/src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c
index 405a45075d..cb2f7f69f5 100644
--- a/src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c
@@ -52,19 +52,6 @@
#include <console/console.h>
#include <commonlib/loglevel.h>
-// TODO These need to be replaced with calls to CreateStruct()
-AGESA_STATUS
-HeapAllocateBuffer (
- IN OUT VOID *AllocateHeapParams,
- IN OUT VOID *StdHeader
- );
-
-AGESA_STATUS
-HeapDeallocateBuffer (
- IN UINT32 BufferHandle,
- IN VOID *StdHeader
- );
-
CONST UINT32 ImageSignature = IMAGE_SIGNATURE;
CONST UINT32 ModuleSignature = MODULE_SIGNATURE;
CONST CHAR8 ModuleIdentifier[] = AGESA_ID;
@@ -415,53 +402,6 @@ FchInitS3LateRestore (
Dispatcher(FchDataPtr);
}
-// TODO This has to be removed
-AGESA_STATUS
-HeapAllocateBuffer (
- IN OUT VOID *AllocateHeapParams,
- IN OUT VOID *StdHeader
- )
-{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
-
- AMD_INTERFACE_PARAMS InterfaceParams = {};
-
- if (!module) return AGESA_UNSUPPORTED;
- Dispatcher = module->ModuleDispatcher;
-
- InterfaceParams.StdHeader = *(AMD_CONFIG_PARAMS*)StdHeader;
- InterfaceParams.StdHeader.Func = AMD_HEAP_ALLOCATE_BUFFER;
-
- InterfaceParams.AllocationMethod = PreMemHeap;
- InterfaceParams.NewStructPtr = AllocateHeapParams;
-
- return Dispatcher(&InterfaceParams);
-}
-
-// TODO This has to be removed
-AGESA_STATUS
-HeapDeallocateBuffer (
- IN UINT32 BufferHandle,
- IN VOID *StdHeader
- )
-{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
-
- AMD_INTERFACE_PARAMS InterfaceParams = {};
-
- if (!module) return AGESA_UNSUPPORTED;
- Dispatcher = module->ModuleDispatcher;
-
- InterfaceParams.StdHeader = *(AMD_CONFIG_PARAMS*)StdHeader;
- InterfaceParams.StdHeader.Func = AMD_HEAP_DEALLOCATE_BUFFER;
-
- InterfaceParams.NewStructPtr = &BufferHandle;
-
- return Dispatcher(&InterfaceParams);
-}
-
/**********************************************************************
* Interface call: AmdSetValue
**********************************************************************/
diff --git a/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c
index 25364d859f..f233542863 100644
--- a/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c
@@ -49,19 +49,6 @@
#include "FchDef.h"
#include "amdlib.h"
-// TODO These need to be replaced with calls to CreateStruct()
-AGESA_STATUS
-HeapAllocateBuffer (
- IN OUT VOID *AllocateHeapParams,
- IN OUT VOID *StdHeader
- );
-
-AGESA_STATUS
-HeapDeallocateBuffer (
- IN UINT32 BufferHandle,
- IN VOID *StdHeader
- );
-
CONST UINT32 ImageSignature = IMAGE_SIGNATURE;
CONST UINT32 ModuleSignature = MODULE_SIGNATURE;
CONST CHAR8 ModuleIdentifier[] = AGESA_ID;
@@ -524,53 +511,6 @@ ImcIdle (
((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
}
-// TODO This has to be removed
-AGESA_STATUS
-HeapAllocateBuffer (
- IN OUT VOID *AllocateHeapParams,
- IN OUT VOID *StdHeader
- )
-{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
-
- AMD_INTERFACE_PARAMS InterfaceParams = {};
-
- if (!module) return AGESA_UNSUPPORTED;
- Dispatcher = module->ModuleDispatcher;
-
- InterfaceParams.StdHeader = *(AMD_CONFIG_PARAMS*)StdHeader;
- InterfaceParams.StdHeader.Func = AMD_HEAP_ALLOCATE_BUFFER;
-
- InterfaceParams.AllocationMethod = PreMemHeap;
- InterfaceParams.NewStructPtr = AllocateHeapParams;
-
- return Dispatcher(&InterfaceParams);
-}
-
-// TODO This has to be removed
-AGESA_STATUS
-HeapDeallocateBuffer (
- IN UINT32 BufferHandle,
- IN VOID *StdHeader
- )
-{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
-
- AMD_INTERFACE_PARAMS InterfaceParams = {};
-
- if (!module) return AGESA_UNSUPPORTED;
- Dispatcher = module->ModuleDispatcher;
-
- InterfaceParams.StdHeader = *(AMD_CONFIG_PARAMS*)StdHeader;
- InterfaceParams.StdHeader.Func = AMD_HEAP_DEALLOCATE_BUFFER;
-
- InterfaceParams.NewStructPtr = &BufferHandle;
-
- return Dispatcher(&InterfaceParams);
-}
-
/**********************************************************************
* Interface call: AmdSetValue
**********************************************************************/