summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVladimir Serbinenko <phcoder@gmail.com>2013-11-23 14:46:34 +0100
committerVladimir Serbinenko <phcoder@gmail.com>2013-11-23 18:40:40 +0100
commit617f853ae43ce1c15fbec1ecba2aa5624f6b4c7d (patch)
tree7a641d78996683ea8155e9a443bed5969bd84939
parent71f35ebdaab56e4ff1d4d882d2cd4f29bda1aacc (diff)
downloadcoreboot-617f853ae43ce1c15fbec1ecba2aa5624f6b4c7d.tar.xz
lib/coreboot_table: set type and size of framebuffer tag after fill_lb_framebuffer
When testing Ron's patch on qemu I found out that fill_lb_framebuffer overwrites size and tag fields. We need either to fix/check all fill_lb_framebuffer implementations or write tag/size after fill_lb_framebuffer. I prefer later as it's more robust. Change-Id: I98f5bac14f65fb4d990cb21426d402b27f2e8a48 Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com> Reviewed-on: http://review.coreboot.org/4263 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
-rw-r--r--src/lib/coreboot_table.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c
index e5729ba6fc..a0a806d7fc 100644
--- a/src/lib/coreboot_table.c
+++ b/src/lib/coreboot_table.c
@@ -177,9 +177,9 @@ static void lb_framebuffer(struct lb_header *header)
return;
struct lb_framebuffer *framebuffer;
framebuffer = (struct lb_framebuffer *)lb_new_record(header);
+ fill_lb_framebuffer(framebuffer);
framebuffer->tag = LB_TAG_FRAMEBUFFER;
framebuffer->size = sizeof(*framebuffer);
- fill_lb_framebuffer(framebuffer);
#endif
}