summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSridhar Siricilla <sridhar.siricilla@intel.com>2020-01-19 12:38:56 +0530
committerPatrick Georgi <pgeorgi@google.com>2020-02-09 19:20:16 +0000
commit63be9181cba7b05e3ed3578415cbb589ffa9d4c2 (patch)
treedd7ee5ac86ba89ddd8913d248dc380184f97da7a
parentff072e6ebfb4f3cf5736e317688930e588a62ec2 (diff)
downloadcoreboot-63be9181cba7b05e3ed3578415cbb589ffa9d4c2.tar.xz
soc/intel/common: Add description to HMRFPO status
Below changes are implemented: 1. Fix typos. 2. Rename 'padding' field of hmrfpo_get_status_resp struct to 'reserved' to match with ME BWG Guide. 3. Add documentation for HMRFPO Status. TEST=Build and boot hatch Change-Id: I4db9bdf7386c48e17ed0373cf334ccff358d1951 Signed-off-by: Sridhar Siricilla <sridhar.siricilla@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/38480 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
-rw-r--r--src/soc/intel/common/block/cse/cse.c4
-rw-r--r--src/soc/intel/common/block/include/intelblocks/cse.h8
2 files changed, 10 insertions, 2 deletions
diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c
index 8fbaba5a2c..d323c76b74 100644
--- a/src/soc/intel/common/block/cse/cse.c
+++ b/src/soc/intel/common/block/cse/cse.c
@@ -683,7 +683,7 @@ failed:
/*
* Sends HMRFPO Get Status command to CSE to get the HMRFPO status.
- * The status can be DISABLES/LOCKED/ENABLED
+ * The status can be DISABLED/LOCKED/ENABLED
*/
int cse_hmrfpo_get_status(void)
{
@@ -694,7 +694,7 @@ int cse_hmrfpo_get_status(void)
struct hmrfpo_get_status_resp {
struct mkhi_hdr hdr;
uint8_t status;
- uint8_t padding[3];
+ uint8_t reserved[3];
} __packed;
struct hmrfpo_get_status_msg msg = {
diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h
index 6233f7d193..1377bd43fb 100644
--- a/src/soc/intel/common/block/include/intelblocks/cse.h
+++ b/src/soc/intel/common/block/include/intelblocks/cse.h
@@ -144,8 +144,16 @@ int cse_hmrfpo_get_status(void);
#define CSE_RESET_ONLY 3
/* HMRFPO Status types */
+/* Host can't access ME region */
#define MKHI_HMRFPO_DISABLED 0
+
+/*
+ * ME Firmware locked down HMRFPO Feature.
+ * Host can't access ME region.
+ */
#define MKHI_HMRFPO_LOCKED 1
+
+/* Host can access ME region */
#define MKHI_HMRFPO_ENABLED 2
/*