summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEdward O'Callaghan <eocallaghan@alterapraxis.com>2015-01-14 02:14:21 +1100
committerEdward O'Callaghan <eocallaghan@alterapraxis.com>2015-01-15 17:12:13 +0100
commit660ec7cfdf0b48c135ada6cd67af25d66404d3ba (patch)
tree378e252f25afb3d8385f3b2a31c9f9f0194e331f
parentb0a00c996d8d60cf207156f0a5176310dc4d7403 (diff)
downloadcoreboot-660ec7cfdf0b48c135ada6cd67af25d66404d3ba.tar.xz
drivers/i2c/w83795: Fix tautology from wrong return type
The correct type-signature of 'do_smbus_write_byte' is: int do_smbus_write_byte(u32 smbus_io_base, u32 device, u32 address, u8 val) and so storing the return type in a 'u32' is inappropriate, leading to a tautological compare of 'ret < 0' and 'err < 0'. Change-Id: I65486df7156c70af84fa00c336142d9a45998620 Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Reviewed-on: http://review.coreboot.org/8209 Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
-rw-r--r--src/drivers/i2c/w83795/w83795.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/drivers/i2c/w83795/w83795.c b/src/drivers/i2c/w83795/w83795.c
index 569fe5ac3c..397c22ca02 100644
--- a/src/drivers/i2c/w83795/w83795.c
+++ b/src/drivers/i2c/w83795/w83795.c
@@ -24,14 +24,14 @@
#include "southbridge/amd/cimx/sb700/smbus.h" /*SMBUS_IO_BASE*/
#include "w83795.h"
-static u32 w83795_set_bank(u8 bank)
+static int w83795_set_bank(u8 bank)
{
return do_smbus_write_byte(SMBUS_IO_BASE, W83795_DEV, W83795_REG_BANKSEL, bank);
}
static u8 w83795_read(u16 reg)
{
- u32 ret;
+ int ret;
ret = w83795_set_bank(reg >> 8);
if (ret < 0) {
@@ -45,7 +45,7 @@ static u8 w83795_read(u16 reg)
static u8 w83795_write(u16 reg, u8 value)
{
- u32 err;
+ int err;
err = w83795_set_bank(reg >> 8);
if (err < 0) {