summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2018-12-16 22:38:58 +0100
committerPatrick Georgi <pgeorgi@google.com>2018-12-18 13:22:11 +0000
commit7ccb2821d27624d97e9728629bf675242d4966d8 (patch)
tree5c42111adb90ed7e73c8552b2527207d0277b1e2
parent3080fe0a0c3936537018857b49e93b15084469ea (diff)
downloadcoreboot-7ccb2821d27624d97e9728629bf675242d4966d8.tar.xz
util/board_status.sh: Fix command for fetching the kernel log
94b761c8e (util/board_status: run dmesg with sudo) attempted to fetch the console as root locally but instead sudo was put in front of the remote path which runs as root anyways. Also unless quotation marks are used the cmd function will see 'sudo' and 'dmesg' as separate aruguments. Change-Id: Ib9e9e4b443f4e3ad04c5fda2c2ce626255a190f2 Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/30264 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
-rwxr-xr-xutil/board_status/board_status.sh4
1 files changed, 2 insertions, 2 deletions
diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh
index bba3d1f6b1..0dc96e8bd7 100755
--- a/util/board_status/board_status.sh
+++ b/util/board_status/board_status.sh
@@ -381,7 +381,7 @@ elif [ -n "$REMOTE_HOST" ]; then
cmd_nonfatal $REMOTE "$cbmem_cmd -t" "${tmpdir}/${results}/coreboot_timestamps.txt"
echo "Getting remote dmesg"
- cmd $REMOTE sudo dmesg "${tmpdir}/${results}/kernel_log.txt"
+ cmd $REMOTE dmesg "${tmpdir}/${results}/kernel_log.txt"
else
echo "Verifying that CBMEM is available"
if [ $(id -u) -ne 0 ]; then
@@ -403,7 +403,7 @@ else
cmd_nonfatal $LOCAL "$cbmem_cmd -t" "${tmpdir}/${results}/coreboot_timestamps.txt"
echo "Getting local dmesg"
- cmd $LOCAL dmesg "${tmpdir}/${results}/kernel_log.txt"
+ cmd $LOCAL "sudo dmesg" "${tmpdir}/${results}/kernel_log.txt"
fi
#