summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEdward O'Callaghan <eocallaghan@alterapraxis.com>2014-04-15 20:30:49 +1000
committerKyösti Mälkki <kyosti.malkki@gmail.com>2014-06-03 09:37:03 +0200
commit8f45761a67347050058537f6a6cd75489af6c1d8 (patch)
treea7ed267f78e0e580f4dcc506fa2ff48ace8f02cb
parent6fb379a1dbd60fcdd8ad30550b708ed1b9e3fa7d (diff)
downloadcoreboot-8f45761a67347050058537f6a6cd75489af6c1d8.tar.xz
superio/ite/it8661f: Make early_serial into romstage sym
Following similar reasoning as commit: d304331 superio/fintek/f81865f: Avoid .c includes Avoid any mistaken future inclusion of early_serial.c in mainboard.c code by providing symbols in romstage. Change-Id: I9e763a7ad9de090e35acdcf4d6a280d8227c6015 Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Reviewed-on: http://review.coreboot.org/5508 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
-rw-r--r--src/superio/ite/it8661f/Makefile.inc2
-rw-r--r--src/superio/ite/it8661f/early_serial.c3
-rw-r--r--src/superio/ite/it8661f/it8661f.h8
3 files changed, 8 insertions, 5 deletions
diff --git a/src/superio/ite/it8661f/Makefile.inc b/src/superio/ite/it8661f/Makefile.inc
index f6f30db0b3..af4e8780e5 100644
--- a/src/superio/ite/it8661f/Makefile.inc
+++ b/src/superio/ite/it8661f/Makefile.inc
@@ -18,5 +18,5 @@
## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
##
+romstage-$(CONFIG_SUPERIO_ITE_IT8661F) += early_serial.c
ramstage-$(CONFIG_SUPERIO_ITE_IT8661F) += superio.c
-
diff --git a/src/superio/ite/it8661f/early_serial.c b/src/superio/ite/it8661f/early_serial.c
index ee132fa077..7373f71975 100644
--- a/src/superio/ite/it8661f/early_serial.c
+++ b/src/superio/ite/it8661f/early_serial.c
@@ -19,6 +19,7 @@
*/
#include <arch/io.h>
+#include <device/pnp.h>
#include "it8661f.h"
/* Perform MB PnP setup to put the SIO chip at 0x3f0. */
@@ -68,7 +69,7 @@ static void it8661f_set_clkin(device_t dev, u8 clkin)
pnp_exit_ext_func_mode(dev);
}
-static void it8661f_enable_serial(device_t dev, u16 iobase)
+void it8661f_enable_serial(device_t dev, u16 iobase)
{
pnp_enter_ext_func_mode(dev);
pnp_set_logical_device(dev);
diff --git a/src/superio/ite/it8661f/it8661f.h b/src/superio/ite/it8661f/it8661f.h
index 5a51f02e25..045a54c46c 100644
--- a/src/superio/ite/it8661f/it8661f.h
+++ b/src/superio/ite/it8661f/it8661f.h
@@ -18,8 +18,8 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
-#ifndef SUPERIO_ITE_IT8661F_IT8661F_H
-#define SUPERIO_ITE_IT8661F_IT8661F_H
+#ifndef SUPERIO_ITE_IT8661F_H
+#define SUPERIO_ITE_IT8661F_H
/* Datasheet: http://www.ite.com.tw/product_info/PC/Brief-IT8661_2.asp */
@@ -52,4 +52,6 @@ static const u8 init_values[] = {
0xe8, 0x74, 0x3a, 0x9d, /**/ 0xce, 0xe7, 0x73, 0x39,
};
-#endif
+void it8661f_enable_serial(device_t dev, u16 iobase);
+
+#endif /* SUPERIO_ITE_IT8661F_H */