summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Georgi <patrick@georgi-clan.de>2015-02-22 16:13:57 +0100
committerPatrick Georgi <pgeorgi@google.com>2015-02-23 20:33:38 +0100
commitb4ad5d0a93e60e887bcda9819597954e72115272 (patch)
tree6db3c6a24ddc39225efa16ea060157d4e9cc62e6
parent1f565b40235a6e0dccbf563c6592b175437fc3f7 (diff)
downloadcoreboot-b4ad5d0a93e60e887bcda9819597954e72115272.tar.xz
drivers/xgi: Avoid double-free
xgifb_probe() doesn't own the object it tries to free in its error code path, potentially leading to a double-free in xgi_z9s_init(). Since we don't actually implement free, it doesn't matter too much, but let's keep things proper. Change-Id: I70c8f395fd59584664040ca6e07be56e046c80fc Signed-off-by: Patrick Georgi <patrick@georgi-clan.de> Found-by: Coverity Scan Reviewed-on: http://review.coreboot.org/8506 Reviewed-by: Timothy Pearson <tpearson@raptorengineeringinc.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> Tested-by: build bot (Jenkins)
-rw-r--r--src/drivers/xgi/common/xgi_coreboot.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/drivers/xgi/common/xgi_coreboot.c b/src/drivers/xgi/common/xgi_coreboot.c
index 361bd628e4..324a0fa981 100644
--- a/src/drivers/xgi/common/xgi_coreboot.c
+++ b/src/drivers/xgi/common/xgi_coreboot.c
@@ -333,7 +333,6 @@ int xgifb_probe(struct pci_dev *pdev, struct xgifb_video_info *xgifb_info)
error_1:
error_disable:
- free(xgifb_info);
return ret;
}