summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Spiegel <richard.spiegel@amd.corp-partner.google.com>2018-10-23 08:59:18 -0700
committerPatrick Georgi <pgeorgi@google.com>2018-11-16 09:41:23 +0000
commitbc0c364ea3ef0332f19fd4a04d81d02c8d72832e (patch)
treec7aa1cf595a334227facbf134fc6067834dd6e1c
parent9eb4d0a0692ca960d6ed1ad14c11e27b32e1f419 (diff)
downloadcoreboot-bc0c364ea3ef0332f19fd4a04d81d02c8d72832e.tar.xz
soc/amd/common: Remove unused variables of write_pci_cfg_irqs()
Function write_pci_cfg_irqs() has "no function" variables. One variable is set and never used, the other is only used to control a print. Remove them. BUG=b:117950052 TEST=Build grunt. Change-Id: Icd98db3e794e609b112f15979a3a00a2977a0fdb Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com> Reviewed-on: https://review.coreboot.org/29244 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
-rw-r--r--src/soc/amd/common/block/pci/amd_pci_util.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/src/soc/amd/common/block/pci/amd_pci_util.c b/src/soc/amd/common/block/pci/amd_pci_util.c
index 983cead894..44a2e61543 100644
--- a/src/soc/amd/common/block/pci/amd_pci_util.c
+++ b/src/soc/amd/common/block/pci/amd_pci_util.c
@@ -104,9 +104,7 @@ void write_pci_cfg_irqs(void)
u16 target_pin = 0;
u16 int_line = 0;
u16 pci_intr_idx = 0; /* Index into PCI_INTR table, 0xC00/0xC01 */
- u8 bus = 0; /* TODO: no longer used, remove it */
u16 devfn = 0;
- u8 bridged_device = 0; /* TODO: Remove this */
u32 i = 0;
size_t limit;
const struct irq_idx_name *idx_name;
@@ -141,7 +139,6 @@ void write_pci_cfg_irqs(void)
if (int_pin < 1 || int_pin > 4)
continue; /* Device has invalid INT_PIN - skip */
- bus = target_dev->bus->secondary;
devfn = target_dev->path.pci.devfn;
/*
@@ -217,10 +214,6 @@ void write_pci_cfg_irqs(void)
*/
printk(BIOS_SPEW, "\tOrig INT_PIN\t: %d (%s)\n",
int_pin, pin_to_str(int_pin));
- if (bridged_device)
- printk(BIOS_SPEW, "\tSwizzled to\t: %d (%s)\n",
- target_pin, pin_to_str(target_pin));
-
printk(BIOS_SPEW, "\tPCI_INTR idx\t: 0x%02x (%s)\n"
"\tINT_LINE\t: 0x%X (IRQ %d)\n",
pci_intr_idx, idx_name[i].name,