diff options
| author | Lijian Zhao <lijian.zhao@intel.com> | 2017-12-15 19:10:18 -0800 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-12-22 16:54:36 +0000 |
| commit | c50296d997ee9d8643f8bf5d1fce1842194c9cc9 (patch) | |
| tree | 0786bbfc333f9f9398917464d0e098a798163be9 | |
| parent | ceac787a4f5d20ca6b0358bf4dd35f47509b2427 (diff) | |
| download | coreboot-c50296d997ee9d8643f8bf5d1fce1842194c9cc9.tar.xz | |
soc/intel: Treat time-out as failure in HECI
If HECI gets times out when waiting for read slots, there's no need to
read back reply message to decide if the HECI recieve successed or not.
Otherwise, system will stuck after global reset required.
BUG=b:707290799
TEST=Boot up meowth board without battery, and confirm hard reset got
trigged after heci time out.
Change-Id: I7c1655284d7027294d8ff5d6a5dbbebe4cbd0c47
Signed-off-by: Lijian Zhao <lijian.zhao@intel.com>
Reviewed-on: https://review.coreboot.org/22910
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
| -rw-r--r-- | src/soc/intel/cannonlake/reset.c | 11 | ||||
| -rw-r--r-- | src/soc/intel/common/block/cse/cse.c | 4 |
2 files changed, 10 insertions, 5 deletions
diff --git a/src/soc/intel/cannonlake/reset.c b/src/soc/intel/cannonlake/reset.c index 03f9cb812b..512fbbe0f3 100644 --- a/src/soc/intel/cannonlake/reset.c +++ b/src/soc/intel/cannonlake/reset.c @@ -25,6 +25,7 @@ /* Reset Request */ #define MKHI_GLOBAL_RESET 0x0b +#define MKHI_STATUS_SUCCESS 0 #define GR_ORIGIN_BIOS_MEM_INIT 0x01 #define GR_ORIGIN_BIOS_POST 0x02 @@ -67,13 +68,13 @@ static int send_heci_reset_message(void) reply_size = sizeof(reply); memset(&reply, 0, reply_size); - heci_receive(&reply, &reply_size); - /* get reply result from HECI MSG */ - if (reply.result != 0) { - printk(BIOS_DEBUG, "%s: Exit with Failure\n", __func__); + if (!heci_receive(&reply, &reply_size)) + return -1; + if (reply.result != MKHI_STATUS_SUCCESS) { + printk(BIOS_DEBUG, "Returned Mkhi Status is not success!\n"); return -1; } - printk(BIOS_DEBUG, "%s: Exit with Success\n", __func__); + printk(BIOS_DEBUG, "Heci recieve success!\n"); return 0; } diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index 370074e222..0ff999e199 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -438,6 +438,10 @@ int heci_receive(void *buff, size_t *maxlen) */ do { received = recv_one_message(&hdr, p, left); + if (!received) { + printk(BIOS_ERR, "HECI: Failed to recieve!\n"); + return 0; + } left -= received; p += received; /* If we read out everything ping to send more */ |