summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPrabal Saha <coolstarorganization@gmail.com>2016-10-13 07:52:23 -0700
committerNico Huber <nico.h@gmx.de>2016-11-25 20:50:00 +0100
commitc7098a61b1b8caf1fc9426bbf7adce9e2631482f (patch)
tree3a278ca9a1bec650b8be8597fcba129748d099ed
parentbf618cb94ea3e4a131ea61dab3702363afa94286 (diff)
downloadcoreboot-c7098a61b1b8caf1fc9426bbf7adce9e2631482f.tar.xz
google/parrot: Fix keyboard interrupts, DSDT
Commit 967cd9a [ChromeOS: fix Kconfig dependencies] broke keyboard interrupts on parrot by making SERIRQ_CONTINUOUS_MODE conditional on CONFIG_CHROMEOS, which it should not be; fix by moving back under main board specific options config. Additionally, Windows [8/8.1/10] fails to enumerate the keyboard when its ACPI entry is located under the SIO device since it is missing an _HID entry, so add the appropriate value per ACPI spec 5 ch. 9.7 Change-Id: Ia69e9b326001d2026b15b4ec03c94f7d03c8a700 Signed-off-by: Prabal Saha <coolstarorganization@gmail.com> Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/17017 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber <nico.h@gmx.de>
-rw-r--r--src/ec/compal/ene932/acpi/superio.asl1
-rw-r--r--src/mainboard/google/parrot/Kconfig5
2 files changed, 3 insertions, 3 deletions
diff --git a/src/ec/compal/ene932/acpi/superio.asl b/src/ec/compal/ene932/acpi/superio.asl
index 8eba623417..f152bbab57 100644
--- a/src/ec/compal/ene932/acpi/superio.asl
+++ b/src/ec/compal/ene932/acpi/superio.asl
@@ -16,6 +16,7 @@
// Scope is \_SB.PCI0.LPCB
Device (SIO) {
+ Name (_HID, EisaId("PNP0A05"))
Name (_UID, 0)
Name (_ADR, 0)
diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig
index 974c58fd76..7b6b49b98a 100644
--- a/src/mainboard/google/parrot/Kconfig
+++ b/src/mainboard/google/parrot/Kconfig
@@ -14,13 +14,12 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select MAINBOARD_HAS_CHROMEOS
select MAINBOARD_HAS_LPC_TPM
select INTEL_INT15
+ # Workaround for EC/KBC IRQ1.
+ select SERIRQ_CONTINUOUS_MODE
config CHROMEOS
select VBOOT_VBNV_CMOS
- # Workaround for EC/KBC IRQ1.
- select SERIRQ_CONTINUOUS_MODE
-
config MAINBOARD_DIR
string
default google/parrot