summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Vaccaro <nvaccaro@google.com>2017-12-20 17:18:01 -0800
committerPatrick Georgi <pgeorgi@google.com>2018-03-08 18:24:05 +0000
commitcb06fab1fcb17cf9fd82b2d74c2eb2e319f2bba2 (patch)
tree3fe00f80b6045f292ec090d40b7f1633560524ad
parent5d6ab45dbb641187f82b4e3ed7487488ccd4971c (diff)
downloadcoreboot-cb06fab1fcb17cf9fd82b2d74c2eb2e319f2bba2.tar.xz
soc/intel/common/block/gspi: set cs polarity before using
Move call to __gspi_cs_change() in gspi_ctrlr_setup() to after initialization of cs polarity since it requires polarity to be set to work properly. Failure to do so confuses cr50. BUG=b:70628116 BRANCH=chromeos-2016.05 TEST='emerge-meowth coreboot' and verify on scope that chip select polarity is correct for the first transaction. Change-Id: I20b4f584663477d751a07889bccc865efbf9c469 Signed-off-by: Nick Vaccaro <nvaccaro@google.com> Reviewed-on: https://review.coreboot.org/25013 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Caveh Jalali <caveh@google.com> Reviewed-by: Furquan Shaikh <furquan@google.com>
-rw-r--r--src/soc/intel/common/block/gspi/gspi.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/soc/intel/common/block/gspi/gspi.c b/src/soc/intel/common/block/gspi/gspi.c
index 2f574a4eb9..60c7391ad0 100644
--- a/src/soc/intel/common/block/gspi/gspi.c
+++ b/src/soc/intel/common/block/gspi/gspi.c
@@ -414,9 +414,6 @@ static int gspi_ctrlr_setup(const struct spi_slave *dev)
/* Take controller out of reset, keeping DMA in reset. */
gspi_write_mmio_reg(p, RESETS, CTRLR_ACTIVE | DMA_RESET);
- /* De-assert chip select. */
- __gspi_cs_change(p, CS_DEASSERT);
-
/*
* CS control:
* - Set SW mode.
@@ -430,6 +427,9 @@ static int gspi_ctrlr_setup(const struct spi_slave *dev)
cs_ctrl |= gspi_csctrl_state(pol, CS_DEASSERT);
gspi_write_mmio_reg(p, SPI_CS_CONTROL, cs_ctrl);
+ /* De-assert chip select. */
+ __gspi_cs_change(p, CS_DEASSERT);
+
/* Disable SPI controller. */
gspi_write_mmio_reg(p, SSCR0, SSCR0_SSE_DISABLE);