summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRaul E Rangel <rrangel@chromium.org>2018-07-16 09:21:11 -0600
committerMartin Roth <martinroth@google.com>2018-07-17 15:30:10 +0000
commitd29c81d51314806f17e0b49cb57f0d620bde783c (patch)
treec4fbef13d818e6b2dcea9a6b7e658123035b1adb
parentc534a066d8808e97eee9ccd2ac2bc936961a129b (diff)
downloadcoreboot-d29c81d51314806f17e0b49cb57f0d620bde783c.tar.xz
libpayload/xhci: Check noop return code when debugging
Make it obvious that the command has failed. BUG=b:76831439 TEST=Verified on grunt Change-Id: Ifa0b2fb087f5f0a36ba017a774fc98b33ab035a4 Signed-off-by: Raul E Rangel <rrangel@chromium.org> Reviewed-on: https://review.coreboot.org/27478 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Julius Werner <jwerner@chromium.org>
-rw-r--r--payloads/libpayload/drivers/usb/xhci.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/payloads/libpayload/drivers/usb/xhci.c b/payloads/libpayload/drivers/usb/xhci.c
index 2e70316ac7..8972ffaf1d 100644
--- a/payloads/libpayload/drivers/usb/xhci.c
+++ b/payloads/libpayload/drivers/usb/xhci.c
@@ -403,9 +403,12 @@ xhci_reinit (hci_t *controller)
xhci_post_command(xhci);
/* Wait for result in event ring */
- xhci_wait_for_command_done(xhci, cmd, 1);
- xhci_debug("Command ring is %srunning\n",
- (xhci->opreg->crcr_lo & CRCR_CRR) ? "" : "not ");
+ int cc = xhci_wait_for_command_done(xhci, cmd, 1);
+
+ xhci_debug("Command ring is %srunning: cc: %d\n",
+ (xhci->opreg->crcr_lo & CRCR_CRR) ? "" : "not ", cc);
+ if (cc != CC_SUCCESS)
+ xhci_debug("noop command failed.\n");
}
#endif
}