diff options
| author | Duncan Laurie <dlaurie@chromium.org> | 2013-06-04 10:06:25 -0700 |
|---|---|---|
| committer | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2013-12-03 01:25:11 +0100 |
| commit | f9da70618e8d6d05aa6e8ae92479e5fc3764d7bd (patch) | |
| tree | 878995f862508a74d6002996fac3c49bddaf41bb | |
| parent | 6a805905cb5737108260174d422b52a5641fc2ff (diff) | |
| download | coreboot-f9da70618e8d6d05aa6e8ae92479e5fc3764d7bd.tar.xz | |
slippy/falco/peppy: Fix Chrome OS GPIO export in ACPI
The OIPG package needs to have >1 member to make the chromeos_acpi
kernel driver do the right automagic sysfs topology creation.
Additionally an "unimplemented" GPIO should be reported as 0xFF
because 0 is a valid GPIO number.
verify crossystem on slippy
$ sudo crossystem | grep -e recoverysw_cur -e wpsw_cur
recoverysw_cur = (error)
wpsw_cur = 1
Change-Id: I06dff09152bde30a3ffe58b1defe9d299155472c
Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/57471
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/4221
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
| -rw-r--r-- | src/mainboard/google/falco/acpi/chromeos.asl | 3 | ||||
| -rw-r--r-- | src/mainboard/google/peppy/acpi/chromeos.asl | 3 | ||||
| -rw-r--r-- | src/mainboard/google/slippy/acpi/chromeos.asl | 3 |
3 files changed, 3 insertions, 6 deletions
diff --git a/src/mainboard/google/falco/acpi/chromeos.asl b/src/mainboard/google/falco/acpi/chromeos.asl index e427821ecb..4e9035be3b 100644 --- a/src/mainboard/google/falco/acpi/chromeos.asl +++ b/src/mainboard/google/falco/acpi/chromeos.asl @@ -18,7 +18,6 @@ */ Name(OIPG, Package() { - // This GPIO is not available but the package cannot be empty - Package () { 0x0001, 0, 0, "LynxPoint" }, // recovery + Package () { 0x0001, 0, 0xFFFFFFFF, "LynxPoint" }, // no recovery button Package () { 0x0003, 1, 58, "LynxPoint" }, // firmware write protect }) diff --git a/src/mainboard/google/peppy/acpi/chromeos.asl b/src/mainboard/google/peppy/acpi/chromeos.asl index e427821ecb..4e9035be3b 100644 --- a/src/mainboard/google/peppy/acpi/chromeos.asl +++ b/src/mainboard/google/peppy/acpi/chromeos.asl @@ -18,7 +18,6 @@ */ Name(OIPG, Package() { - // This GPIO is not available but the package cannot be empty - Package () { 0x0001, 0, 0, "LynxPoint" }, // recovery + Package () { 0x0001, 0, 0xFFFFFFFF, "LynxPoint" }, // no recovery button Package () { 0x0003, 1, 58, "LynxPoint" }, // firmware write protect }) diff --git a/src/mainboard/google/slippy/acpi/chromeos.asl b/src/mainboard/google/slippy/acpi/chromeos.asl index e427821ecb..4e9035be3b 100644 --- a/src/mainboard/google/slippy/acpi/chromeos.asl +++ b/src/mainboard/google/slippy/acpi/chromeos.asl @@ -18,7 +18,6 @@ */ Name(OIPG, Package() { - // This GPIO is not available but the package cannot be empty - Package () { 0x0001, 0, 0, "LynxPoint" }, // recovery + Package () { 0x0001, 0, 0xFFFFFFFF, "LynxPoint" }, // no recovery button Package () { 0x0003, 1, 58, "LynxPoint" }, // firmware write protect }) |