summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKane Chen <kane_chen@pegatron.corp-partner.google.com>2019-10-04 18:39:03 +0800
committerFurquan Shaikh <furquan@google.com>2019-10-30 16:58:26 +0000
commit10af2af81fbf102d3f68fbf4f47364978f59e8ab (patch)
tree8d1164aa729cf0e10322f350574af37fb5b50918
parentff744bf0eee875a03dc98dd6792e3ed0ff4456a0 (diff)
downloadcoreboot-10af2af81fbf102d3f68fbf4f47364978f59e8ab.tar.xz
mb/google/hatch/variants/helios: Modify DPTF parameters
Modify DPTF parameters. Modify TDP PL1 values to 15. Remove TCHG Level 3 - 0.5A. BUG=b:131272830 BRANCH=none TEST=emerge-hatch coreboot chromeos-bootimage Signed-off-by: YenLu Chen <kane_chen@pegatron.corp-partner.google.com> Change-Id: I0e5c079856a167b1c2ef52e446d055404e565858 Reviewed-on: https://review.coreboot.org/c/coreboot/+/35794 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl64
-rw-r--r--src/mainboard/google/hatch/variants/helios/overridetree.cb2
2 files changed, 18 insertions, 48 deletions
diff --git a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl
index 0013f2945d..90943529b6 100644
--- a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl
+++ b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl
@@ -13,46 +13,26 @@
* GNU General Public License for more details.
*/
-#define DPTF_CPU_PASSIVE 95
+#define DPTF_CPU_PASSIVE 0
#define DPTF_CPU_CRITICAL 105
-#define DPTF_CPU_ACTIVE_AC0 87
-#define DPTF_CPU_ACTIVE_AC1 85
-#define DPTF_CPU_ACTIVE_AC2 83
-#define DPTF_CPU_ACTIVE_AC3 80
-#define DPTF_CPU_ACTIVE_AC4 75
#define DPTF_TSR0_SENSOR_ID 0
#define DPTF_TSR0_SENSOR_NAME "Battery Charger"
-#define DPTF_TSR0_PASSIVE 65
-#define DPTF_TSR0_CRITICAL 75
-#define DPTF_TSR0_ACTIVE_AC0 50
-#define DPTF_TSR0_ACTIVE_AC1 47
-#define DPTF_TSR0_ACTIVE_AC2 45
-#define DPTF_TSR0_ACTIVE_AC3 42
-#define DPTF_TSR0_ACTIVE_AC4 40
-#define DPTF_TSR0_ACTIVE_AC5 38
+#define DPTF_TSR0_PASSIVE 50
+#define DPTF_TSR0_CRITICAL 80
#define DPTF_TSR1_SENSOR_ID 1
#define DPTF_TSR1_SENSOR_NAME "5V Regulator"
-#define DPTF_TSR1_PASSIVE 45
-#define DPTF_TSR1_CRITICAL 65
-#define DPTF_TSR1_ACTIVE_AC0 50
-#define DPTF_TSR1_ACTIVE_AC1 47
-#define DPTF_TSR1_ACTIVE_AC2 45
-#define DPTF_TSR1_ACTIVE_AC3 42
-#define DPTF_TSR1_ACTIVE_AC4 40
-#define DPTF_TSR1_ACTIVE_AC5 38
+#define DPTF_TSR1_PASSIVE 0
+#define DPTF_TSR1_CRITICAL 70
+#define DPTF_TSR1_ACTIVE_AC0 43
+#define DPTF_TSR1_ACTIVE_AC1 40
+#define DPTF_TSR1_ACTIVE_AC2 38
#define DPTF_TSR2_SENSOR_ID 2
#define DPTF_TSR2_SENSOR_NAME "Ambient"
-#define DPTF_TSR2_PASSIVE 50
+#define DPTF_TSR2_PASSIVE 0
#define DPTF_TSR2_CRITICAL 65
-#define DPTF_TSR2_ACTIVE_AC0 50
-#define DPTF_TSR2_ACTIVE_AC1 47
-#define DPTF_TSR2_ACTIVE_AC2 45
-#define DPTF_TSR2_ACTIVE_AC3 42
-#define DPTF_TSR2_ACTIVE_AC4 40
-#define DPTF_TSR2_ACTIVE_AC5 38
#define DPTF_TSR3_SENSOR_ID 3
#define DPTF_TSR3_SENSOR_NAME "CPU"
@@ -73,7 +53,6 @@ Name (CHPS, Package () {
Package () { 0, 0, 0, 0, 255, 0x6a4, "mA", 0 }, /* 1.7A (MAX) */
Package () { 0, 0, 0, 0, 24, 0x600, "mA", 0 }, /* 1.5A */
Package () { 0, 0, 0, 0, 16, 0x400, "mA", 0 }, /* 1.0A */
- Package () { 0, 0, 0, 0, 8, 0x200, "mA", 0 }, /* 0.5A */
})
/* DFPS: Fan Performance States */
@@ -104,19 +83,19 @@ Name (DART, Package () {
* Source, Target, Weight, AC0, AC1, AC2, AC3, AC4, AC5, AC6,
* AC7, AC8, AC9
*/
- \_SB.DPTF.TFN1, \_SB.PCI0.TCPU, 100, 100, 80, 60, 55, 40, 0, 0,
+ \_SB.DPTF.TFN1, \_SB.PCI0.TCPU, 100, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0
},
Package () {
- \_SB.DPTF.TFN1, \_SB.DPTF.TSR0, 100, 90, 69, 56, 46, 36, 30, 0,
+ \_SB.DPTF.TFN1, \_SB.DPTF.TSR0, 100, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0
},
Package () {
- \_SB.DPTF.TFN1, \_SB.DPTF.TSR1, 100, 90, 69, 56, 46, 36, 30, 0,
+ \_SB.DPTF.TFN1, \_SB.DPTF.TSR1, 100, 100, 80, 60, 0, 0, 0, 0,
0, 0, 0
},
Package () {
- \_SB.DPTF.TFN1, \_SB.DPTF.TSR2, 100, 90, 69, 56, 46, 36, 30, 0,
+ \_SB.DPTF.TFN1, \_SB.DPTF.TSR2, 100, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0
},
Package () {
@@ -126,20 +105,11 @@ Name (DART, Package () {
})
Name (DTRT, Package () {
- /* CPU Throttle Effect on CPU */
- Package () { \_SB.PCI0.TCPU, \_SB.PCI0.TCPU, 100, 60, 0, 0, 0, 0 },
-
/* CPU Throttle Effect on TSR0 */
Package () { \_SB.PCI0.TCPU, \_SB.DPTF.TSR0, 100, 60, 0, 0, 0, 0 },
- /* Charger Throttle Effect on TSR1 */
- Package () { \_SB.DPTF.TCHG, \_SB.DPTF.TSR1, 100, 60, 0, 0, 0, 0 },
-
- /* CPU Throttle Effect on TSR2 */
- Package () { \_SB.PCI0.TCPU, \_SB.DPTF.TSR2, 100, 60, 0, 0, 0, 0 },
-
- /* CPU Throttle Effect on TSR3 */
- Package () { \_SB.PCI0.TCPU, \_SB.DPTF.TSR3, 100, 60, 0, 0, 0, 0 },
+ /* Charger Throttle Effect on TSR0 */
+ Package () { \_SB.DPTF.TCHG, \_SB.DPTF.TSR0, 100, 60, 0, 0, 0, 0 },
})
Name (MPPC, Package ()
@@ -147,8 +117,8 @@ Name (MPPC, Package ()
0x2, /* Revision */
Package () { /* Power Limit 1 */
0, /* PowerLimitIndex, 0 for Power Limit 1 */
- 8000, /* PowerLimitMinimum */
- 13000, /* PowerLimitMaximum */
+ 10000, /* PowerLimitMinimum */
+ 15000, /* PowerLimitMaximum */
28000, /* TimeWindowMinimum */
28000, /* TimeWindowMaximum */
200 /* StepSize */
diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb
index 2434dfff2a..262ae8d607 100644
--- a/src/mainboard/google/hatch/variants/helios/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb
@@ -1,5 +1,5 @@
chip soc/intel/cannonlake
- register "tdp_pl1_override" = "13"
+ register "tdp_pl1_override" = "15"
register "tdp_pl2_override" = "64"
register "SerialIoDevMode" = "{