summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorV Sowmya <v.sowmya@intel.com>2017-07-11 14:31:18 +0530
committerMartin Roth <martinroth@google.com>2017-07-12 17:24:56 +0000
commit1440c66b16a6c5a1fb4bfaa9511edfeea3f88c18 (patch)
tree8f04ccbd8502fba084d6a00dde988555de097fac
parent76b93fe05f802206f7938416911fcc7e3b2aec91 (diff)
downloadcoreboot-1440c66b16a6c5a1fb4bfaa9511edfeea3f88c18.tar.xz
mb/intel/kblrvp: Enable HD Audio for rvp3
Enable Azalia controller, HD Audio DSP and select the HDAudio IoBuffer Ownership for rvp3. Check if device is enabled in HDA codec init function to avoid failure when Azalia controller is disabled in the devicetree.cb. BUG=None TEST=Build for kblrvp3, Make sure booting is fine irrespective of HDA enable/disable. Change-Id: I87212fe16ecc6053d6d00372904a5fd5d6f6b209 Signed-off-by: V Sowmya <v.sowmya@intel.com> Reviewed-on: https://review.coreboot.org/20530 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Martin Roth <martinroth@google.com>
-rw-r--r--src/mainboard/intel/kblrvp/hda_verb.c2
-rw-r--r--src/mainboard/intel/kblrvp/variants/rvp3/devicetree.cb3
2 files changed, 4 insertions, 1 deletions
diff --git a/src/mainboard/intel/kblrvp/hda_verb.c b/src/mainboard/intel/kblrvp/hda_verb.c
index 8a87968f7f..ba9cc46693 100644
--- a/src/mainboard/intel/kblrvp/hda_verb.c
+++ b/src/mainboard/intel/kblrvp/hda_verb.c
@@ -63,7 +63,7 @@ static void mb_hda_codec_init(void *unused)
/* Find base address */
dev = dev_find_slot(0, PCH_DEVFN_HDA);
- if (dev == NULL)
+ if (dev == NULL || dev->enabled == 0)
return;
res = find_resource(dev, PCI_BASE_ADDRESS_0);
if (!res)
diff --git a/src/mainboard/intel/kblrvp/variants/rvp3/devicetree.cb b/src/mainboard/intel/kblrvp/variants/rvp3/devicetree.cb
index 23c8d3c962..ac99a211ef 100644
--- a/src/mainboard/intel/kblrvp/variants/rvp3/devicetree.cb
+++ b/src/mainboard/intel/kblrvp/variants/rvp3/devicetree.cb
@@ -24,6 +24,9 @@ chip soc/intel/skylake
register "dptf_enable" = "1"
# FSP Configuration
+ register "EnableAzalia" = "1"
+ register "DspEnable" = "1"
+ register "IoBufferOwnership" = "0"
register "SmbusEnable" = "1"
register "ScsEmmcEnabled" = "1"
register "ScsEmmcHs400Enabled" = "1"