diff options
author | Nico Huber <nico.h@gmx.de> | 2019-06-08 19:49:48 +0200 |
---|---|---|
committer | Nico Huber <nico.h@gmx.de> | 2019-09-20 07:57:20 +0000 |
commit | 26e59a62809d5f0f8d5f4469441490544506978d (patch) | |
tree | 109fb569d1e61d5213a8c69f896a494dd5028196 | |
parent | c157ee97d422f3afa406926b5f9a291a8478532f (diff) | |
download | coreboot-26e59a62809d5f0f8d5f4469441490544506978d.tar.xz |
sb/intel/common/fw: Make make aware that it needs binaries
As we redirect all `dd` output to /dev/null (it would clutter the
console otherwise), there is no error message if a binary to be
added isn't found. If we add them as dependency, OTOH, `make` will
complain properly.
Change-Id: I40c3979b84341cb88c7e9a5084c1a97230ea5503
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33327
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r-- | src/southbridge/intel/common/firmware/Makefile.inc | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/src/southbridge/intel/common/firmware/Makefile.inc b/src/southbridge/intel/common/firmware/Makefile.inc index 898ab60770..e7060361bd 100644 --- a/src/southbridge/intel/common/firmware/Makefile.inc +++ b/src/southbridge/intel/common/firmware/Makefile.inc @@ -31,6 +31,16 @@ ifneq ($(call strip_quotes,$(CONFIG_IFD_CHIPSET)),) IFDTOOL_USE_CHIPSET := -p $(CONFIG_IFD_CHIPSET) endif +add_intel_firmware: $(call strip_quotes,$(CONFIG_IFD_BIN_PATH)) +ifeq ($(CONFIG_HAVE_ME_BIN),y) +add_intel_firmware: $(call strip_quotes,$(CONFIG_ME_BIN_PATH)) +endif +ifeq ($(CONFIG_HAVE_GBE_BIN),y) +add_intel_firmware: $(call strip_quotes,$(CONFIG_GBE_BIN_PATH)) +endif +ifeq ($(CONFIG_HAVE_EC_BIN),y) +add_intel_firmware: $(call strip_quotes,$(CONFIG_EC_BIN_PATH)) +endif add_intel_firmware: $(obj)/coreboot.pre $(IFDTOOL) printf " DD Adding Intel Firmware Descriptor\n" dd if=$(IFD_BIN_PATH) \ |