diff options
| author | Furquan Shaikh <furquan@google.com> | 2020-07-13 11:51:17 -0700 |
|---|---|---|
| committer | Furquan Shaikh <furquan@google.com> | 2020-07-13 21:23:50 +0000 |
| commit | 33d9eeae5fd9bcbf093383e282a4424aaae7d855 (patch) | |
| tree | 3de1ffeebed7fc3c979a7dcc2f8ba3ae671fd276 | |
| parent | 411a6ab70306f567271699abe6c11227b1cd5ffd (diff) | |
| download | coreboot-33d9eeae5fd9bcbf093383e282a4424aaae7d855.tar.xz | |
mb/google/zork: Fix check for variant_uses_v3_schematics()
CB:43224 ("mb/google/zork: Add helpers for v3 schematics and wifi
power enable") added helper functions for determining if a board uses
v3 schematics. However, it introduced a regression by adding a wrong
check for variant_uses_v3_schematics() in variant_audio_update(). This
change fixes the check to ensure that dmic_gpio is updated when
variant is not using v3 schematics.
BUG=b:161141258,b:161128964
TEST=Verified on trembyle that trackpad works again (it was broken
because of the regression).
Signed-off-by: Furquan Shaikh <furquan@google.com>
Change-Id: I0e6ad844f68cface7b545f1547bd94470c30dde4
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43415
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Rob Barnes <robbarnes@google.com>
Reviewed-by: Martin Roth <martinroth@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/mainboard/google/zork/variants/baseboard/ramstage_common.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/zork/variants/baseboard/ramstage_common.c b/src/mainboard/google/zork/variants/baseboard/ramstage_common.c index 143c1b4420..f7f11b88ea 100644 --- a/src/mainboard/google/zork/variants/baseboard/ramstage_common.c +++ b/src/mainboard/google/zork/variants/baseboard/ramstage_common.c @@ -10,7 +10,7 @@ void variant_audio_update(void) struct soc_amd_picasso_config *cfg = config_of_soc(); struct acpi_gpio *gpio = &cfg->dmic_select_gpio; - if (!variant_uses_v3_schematics()) + if (variant_uses_v3_schematics()) return; if (CONFIG(BOARD_GOOGLE_BASEBOARD_TREMBYLE)) |