summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2019-10-03 09:34:57 +0200
committerArthur Heymans <arthur@aheymans.xyz>2019-10-06 10:15:30 +0000
commit38750f88fc0071cce97cbbc8d9f2c9bd35464e97 (patch)
treebc4aebbdbbd09466c9f6e45d49f820688a3e6a13
parent3b452e0a797b54a05b97725f4e4e320c51098754 (diff)
downloadcoreboot-38750f88fc0071cce97cbbc8d9f2c9bd35464e97.tar.xz
nb/intel/nehalem: Don't run graphic init on S3 resume
The assumption is made that an ACPI aware an OS does not rely on firmware to initialize the display. TESTED on a Lenovo Thinkpad X201 with Linux 5.2, display still works after S3, more than 200ms in time saved (dropped from 411ms to 182ms in total in one test). Change-Id: I36219e6d04db561d4f2ddb6e962166c598d5bc4f Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/35773 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Patrick Rudolph <siro@das-labor.org>
-rw-r--r--src/northbridge/intel/nehalem/gma.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/northbridge/intel/nehalem/gma.c b/src/northbridge/intel/nehalem/gma.c
index 43333070ff..903ee273e1 100644
--- a/src/northbridge/intel/nehalem/gma.c
+++ b/src/northbridge/intel/nehalem/gma.c
@@ -176,7 +176,8 @@ static void gma_func0_init(struct device *dev)
if (!gtt_res || !gtt_res->base)
return;
- if (CONFIG(MAINBOARD_USE_LIBGFXINIT)) {
+ if (!acpi_is_wakeup_s3() &&
+ CONFIG(MAINBOARD_USE_LIBGFXINIT)) {
struct northbridge_intel_nehalem_config *conf = dev->chip_info;
int lightup_ok;
printk(BIOS_SPEW, "Initializing VGA without OPROM.");