summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAsami Doi <d0iasm.pub@gmail.com>2019-03-17 14:26:08 +0900
committerPatrick Georgi <pgeorgi@google.com>2019-03-21 16:16:10 +0000
commit6520ec0650c4af616e1da92a5d90263e895f50ca (patch)
treeeeb3c77dc3db608c6ce8b9921ed37579911d34aa
parentabe2f27acfbfaff81be4b9ff5750aa3b057ba0d0 (diff)
downloadcoreboot-6520ec0650c4af616e1da92a5d90263e895f50ca.tar.xz
src/arch/mips: Fix checkpatch warnings and errors
This patch will fix these checkpatch errors in src/arch/mips/. - src/arch/mips/ashldi3.c:22: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' - src/arch/mips/bootblock_simple.c:35: WARNING: braces {} are not necessary for any arm of this statement Change-Id: Ic859913b93dc8ed6ff64b551c8a6baf72d28c75a Signed-off-by: Asami Doi <d0iasm.pub@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/31938 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Julius Werner <jwerner@chromium.org>
-rw-r--r--src/arch/mips/ashldi3.c2
-rw-r--r--src/arch/mips/bootblock_simple.c6
2 files changed, 4 insertions, 4 deletions
diff --git a/src/arch/mips/ashldi3.c b/src/arch/mips/ashldi3.c
index 9ee40efa41..f68d78ed60 100644
--- a/src/arch/mips/ashldi3.c
+++ b/src/arch/mips/ashldi3.c
@@ -19,7 +19,7 @@
#errror "What endian are you!?"
#endif
-typedef unsigned word_type;
+typedef unsigned int word_type;
long long __ashldi3(long long u, word_type b);
struct DWstruct {
diff --git a/src/arch/mips/bootblock_simple.c b/src/arch/mips/bootblock_simple.c
index 40987d8bcd..84029ebedb 100644
--- a/src/arch/mips/bootblock_simple.c
+++ b/src/arch/mips/bootblock_simple.c
@@ -32,10 +32,10 @@ void main(void)
bootblock_mmu_init();
- if (init_extra_hardware()) {
+ if (init_extra_hardware())
printk(BIOS_ERR, "bootblock_simple: failed to init HW.\n");
- } else {
+ else
run_romstage();
- }
+
halt();
}