summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEdward O'Callaghan <eocallaghan@alterapraxis.com>2014-12-08 22:19:48 +1100
committerEdward O'Callaghan <eocallaghan@alterapraxis.com>2014-12-08 17:59:19 +0100
commit698dc74ebada21980781d9adb419b01de8f87d4b (patch)
tree3b37d9c441274e13f3c90b25d3d9f7bfd29da93d
parentb713d93525ec2a5e5ff65b81334b4475841b633c (diff)
downloadcoreboot-698dc74ebada21980781d9adb419b01de8f87d4b.tar.xz
mainboard: Fix correct index variable usage in double loop construct
Change-Id: I672c532c3f7179038d41f269bba434b8703e254b Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Found-by: Clang Reviewed-on: http://review.coreboot.org/7718 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
-rw-r--r--src/mainboard/amd/dinar/rd890_cfg.c2
-rw-r--r--src/mainboard/supermicro/h8qgi/rd890_cfg.c2
-rw-r--r--src/mainboard/supermicro/h8scm/rd890_cfg.c2
-rw-r--r--src/mainboard/tyan/s8226/rd890_cfg.c2
4 files changed, 4 insertions, 4 deletions
diff --git a/src/mainboard/amd/dinar/rd890_cfg.c b/src/mainboard/amd/dinar/rd890_cfg.c
index 783c130625..69c4d41831 100644
--- a/src/mainboard/amd/dinar/rd890_cfg.c
+++ b/src/mainboard/amd/dinar/rd890_cfg.c
@@ -82,7 +82,7 @@ static void nb_platform_config(device_t nb_dev, AMD_NB_CONFIG *NbConfigPtr)
}
if ((platform_config.PortHotplugMap & (1 << i)) != 0) {
u16 j;
- pPcieConfig->PortConfiguration[j].PortHotplug = ON; /* Enable Hotplug */
+ pPcieConfig->PortConfiguration[i].PortHotplug = ON; /* Enable Hotplug */
/* Set Hotplug descriptor info */
for (j = 0; j < 8; j++) {
u32 PortDescriptor;
diff --git a/src/mainboard/supermicro/h8qgi/rd890_cfg.c b/src/mainboard/supermicro/h8qgi/rd890_cfg.c
index 9c91920d48..a5f6650956 100644
--- a/src/mainboard/supermicro/h8qgi/rd890_cfg.c
+++ b/src/mainboard/supermicro/h8qgi/rd890_cfg.c
@@ -82,7 +82,7 @@ static void nb_platform_config(device_t nb_dev, AMD_NB_CONFIG *NbConfigPtr)
}
if ((platform_config.PortHotplugMap & (1 << i)) != 0) {
u16 j;
- pPcieConfig->PortConfiguration[j].PortHotplug = ON; /* Enable Hotplug */
+ pPcieConfig->PortConfiguration[i].PortHotplug = ON; /* Enable Hotplug */
/* Set Hotplug descriptor info */
for (j = 0; j < 8; j++) {
u32 PortDescriptor;
diff --git a/src/mainboard/supermicro/h8scm/rd890_cfg.c b/src/mainboard/supermicro/h8scm/rd890_cfg.c
index 9c91920d48..a5f6650956 100644
--- a/src/mainboard/supermicro/h8scm/rd890_cfg.c
+++ b/src/mainboard/supermicro/h8scm/rd890_cfg.c
@@ -82,7 +82,7 @@ static void nb_platform_config(device_t nb_dev, AMD_NB_CONFIG *NbConfigPtr)
}
if ((platform_config.PortHotplugMap & (1 << i)) != 0) {
u16 j;
- pPcieConfig->PortConfiguration[j].PortHotplug = ON; /* Enable Hotplug */
+ pPcieConfig->PortConfiguration[i].PortHotplug = ON; /* Enable Hotplug */
/* Set Hotplug descriptor info */
for (j = 0; j < 8; j++) {
u32 PortDescriptor;
diff --git a/src/mainboard/tyan/s8226/rd890_cfg.c b/src/mainboard/tyan/s8226/rd890_cfg.c
index 9c91920d48..a5f6650956 100644
--- a/src/mainboard/tyan/s8226/rd890_cfg.c
+++ b/src/mainboard/tyan/s8226/rd890_cfg.c
@@ -82,7 +82,7 @@ static void nb_platform_config(device_t nb_dev, AMD_NB_CONFIG *NbConfigPtr)
}
if ((platform_config.PortHotplugMap & (1 << i)) != 0) {
u16 j;
- pPcieConfig->PortConfiguration[j].PortHotplug = ON; /* Enable Hotplug */
+ pPcieConfig->PortConfiguration[i].PortHotplug = ON; /* Enable Hotplug */
/* Set Hotplug descriptor info */
for (j = 0; j < 8; j++) {
u32 PortDescriptor;