summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSeunghwan Kim <sh_.kim@samsung.corp-partner.google.com>2020-08-13 14:52:37 +0900
committerKarthik Ramasubramanian <kramasub@google.com>2020-08-14 06:55:13 +0000
commit6c22be6298be2ae4fc667d4c44ae2e5bee4afbe4 (patch)
treee6937a9afdbd7cae82b58bcecc7467f38f763b72
parent65880b6868b4d8300124ebf2beb71a2ea8ade4ca (diff)
downloadcoreboot-6c22be6298be2ae4fc667d4c44ae2e5bee4afbe4.tar.xz
mb/google/octopus: Set default value of ModPhyIfValue parameter
Set default value of ModPhyIfValue parameter in FSPS_UPD. Without this setting, it will be set to '0' and system may not detect USB 3.0 device. BUG=b:163382089 BRANCH=firmware-octopus-11297.B TEST=Built Change-Id: Ide3d1637f99dba28251102f771b6ce370cc5d8e4 Signed-off-by: Seunghwan Kim <sh_.kim@samsung.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/44436 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
-rw-r--r--src/mainboard/google/octopus/variants/baseboard/devicetree.cb4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb
index 80e4873694..ea5325a57e 100644
--- a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb
@@ -285,4 +285,8 @@ chip soc/intel/apollolake
# PWROKDELAY[2:0]: 000=2.5ms, 001=5.0ms, 010=10ms, 011=15ms, 100=20ms,
# 101=50ms, 110=75ms, 111=100ms (default)
register "PmicPmcIpcCtrl" = "0x5e4302f8"
+
+ # FSP UPD to modify the Integrated Filter (IF) value
+ # 0x12(Default) for Windows, 0x16 for Chrome
+ register "ModPhyIfValue" = "0x16"
end