diff options
| author | Felix Held <felix-github@felixheld.de> | 2019-06-07 14:47:28 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2019-06-08 10:33:13 +0000 |
| commit | 7f9f3d0cf3924eb64ba20732ffb7a51db8bd0292 (patch) | |
| tree | de9285f83d92125c297a819a8ecf174a58f695d8 | |
| parent | a34b78c981dd8b69f43c2a8c5c582db68f5e5b40 (diff) | |
| download | coreboot-7f9f3d0cf3924eb64ba20732ffb7a51db8bd0292.tar.xz | |
northbridge/gm45: document that raminit doesn't support mirrored ranks
Change-Id: I8a66a1355974f6771c5e4bae0dc60da2447122d1
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33294
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
| -rw-r--r-- | src/northbridge/intel/gm45/raminit.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/northbridge/intel/gm45/raminit.c b/src/northbridge/intel/gm45/raminit.c index 2826d7418c..b7ccdecdad 100644 --- a/src/northbridge/intel/gm45/raminit.c +++ b/src/northbridge/intel/gm45/raminit.c @@ -1593,7 +1593,8 @@ static void jedec_init(const timings_t *const timings, int ch, r; FOR_EACH_POPULATED_RANK(dimms, ch, r) { /* We won't do this in dual-interleaved mode, - so don't care about the offset. */ + so don't care about the offset. + Mirrored ranks aren't taken into account here. */ const u32 rankaddr = raminit_get_rank_addr(ch, r); printk(BIOS_DEBUG, "JEDEC init @0x%08x\n", rankaddr); MCHBAR32(DCC_MCHBAR) = (MCHBAR32(DCC_MCHBAR) & ~DCC_SET_EREG_MASK) | DCC_SET_EREGx(2); |