summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRoy Mingi Park <roy.mingi.park@intel.com>2018-10-10 15:07:59 -0700
committerPatrick Georgi <pgeorgi@google.com>2018-10-17 11:59:54 +0000
commit9814f8f037d4735f2f45b586c20573238d659b31 (patch)
tree985f028b114fc47b2b52e76d060fec4b88e82c0c
parent6c96542a3e7936bcad6e2ea683f9244383a36f59 (diff)
downloadcoreboot-9814f8f037d4735f2f45b586c20573238d659b31.tar.xz
mb/google/poppy/variants/nocturne: Disable pull-down of GPP_E9/E10
While these pins were set to a pull-down 20KOhm, NPCX EC consumes ~2.1mW higher power. Becasue there was leakage current on both GPIO67 and GPIO70 from NPCX EC. With the external pull-up 10KOhm for USB_OC0#/USB2_OC1#, this wasn't enough to prevent leakage current. BUG=b:117139495 TEST=Check nxpc EC power to see power improvement Change-Id: I685d876461c263f07ca4c8f8046635cb7087279c Signed-off-by: Roy Mingi Park <roy.mingi.park@intel.com> Reviewed-on: https://review.coreboot.org/29007 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com> Reviewed-by: Furquan Shaikh <furquan@google.com>
-rw-r--r--src/mainboard/google/poppy/variants/nocturne/gpio.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c
index 8f87705073..16ff982529 100644
--- a/src/mainboard/google/poppy/variants/nocturne/gpio.c
+++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c
@@ -229,9 +229,9 @@ static const struct pad_config gpio_table[] = {
/* E8 : SATALED# ==> NC */
PAD_CFG_NC(GPP_E8),
/* E9 : USB2_OCO# ==> USB_C0_OC_ODL */
- PAD_CFG_NF(GPP_E9, 20K_PD, DEEP, NF1),
+ PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1),
/* E10 : USB2_OC1# ==> USB_C1_OC_ODL */
- PAD_CFG_NF(GPP_E10, 20K_PD, DEEP, NF1),
+ PAD_CFG_NF(GPP_E10, NONE, DEEP, NF1),
/* E11 : USB2_OC2# ==> TOUCHSCREEN_RESET_L */
PAD_CFG_TERM_GPO(GPP_E11, 0, 20K_PD, DEEP),
/* E12 : USB2_OC3# ==> NC */