diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-11-29 00:52:01 +0200 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-11-30 06:01:25 +0000 |
| commit | 9b71804e4fda9bcb067bb06f7d5d5c3f76922327 (patch) | |
| tree | 363f70bf4a2c7a41f75b097799a3d2a536a77a0e | |
| parent | dc34a9d6de6ab21a1f1ed1a6cba142585c092045 (diff) | |
| download | coreboot-9b71804e4fda9bcb067bb06f7d5d5c3f76922327.tar.xz | |
AGESA,binaryPI: Remove BIST reporting in romstage
For easier C environment bootblock transition by using
already existing prototypes, BIST will not be passed
to romstage. It is expected that bootblock will have
equivalent code.
Change-Id: I0f8e3657ac79277cd77c397d1b3e931e33a6f5db
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37348
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/drivers/amd/agesa/romstage.c | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/src/drivers/amd/agesa/romstage.c b/src/drivers/amd/agesa/romstage.c index f9a8c9705a..8460035de4 100644 --- a/src/drivers/amd/agesa/romstage.c +++ b/src/drivers/amd/agesa/romstage.c @@ -16,7 +16,6 @@ #include <arch/romstage.h> #include <cbmem.h> #include <cpu/amd/car.h> -#include <cpu/x86/bist.h> #include <console/console.h> #include <halt.h> #include <program_loading.h> @@ -40,7 +39,7 @@ static void fill_sysinfo(struct sysinfo *cb) agesa_set_interface(cb); } -static void bsp_romstage_main(unsigned long bist) +static void bsp_romstage_main(void) { struct postcar_frame pcf; struct sysinfo romstage_state; @@ -66,9 +65,6 @@ static void bsp_romstage_main(unsigned long bist) printk(BIOS_DEBUG, "APIC %02d: CPU Family_Model = %08x\n", initial_apic_id, cpuid_eax(1)); - /* Halt if there was a built in self test failure */ - report_bist_failure(bist); - agesa_execute_state(cb, AMD_INIT_RESET); agesa_execute_state(cb, AMD_INIT_EARLY); @@ -103,7 +99,7 @@ static void bsp_romstage_main(unsigned long bist) /* We do not return. */ } -static void __noreturn ap_romstage_main(unsigned long bist) +static void __noreturn ap_romstage_main(void) { struct sysinfo romstage_state; struct sysinfo *cb = &romstage_state; @@ -113,9 +109,6 @@ static void __noreturn ap_romstage_main(unsigned long bist) fill_sysinfo(cb); - /* Halt if there was a built in self test failure */ - report_bist_failure(bist); - agesa_execute_state(cb, AMD_INIT_RESET); agesa_execute_state(cb, AMD_INIT_EARLY); @@ -127,7 +120,7 @@ static void __noreturn ap_romstage_main(unsigned long bist) asmlinkage void romstage_main(unsigned long bist) { if (boot_cpu()) - bsp_romstage_main(bist); + bsp_romstage_main(); else - ap_romstage_main(bist); + ap_romstage_main(); } |