diff options
| author | Sven Schnelle <svens@stackframe.org> | 2012-06-20 08:57:11 +0200 |
|---|---|---|
| committer | Sven Schnelle <svens@stackframe.org> | 2012-06-20 09:43:43 +0200 |
| commit | 9b860165bac4153517f46d655e5f67a25326214b (patch) | |
| tree | dc554fd76754e36f9f9fa5cc57b199ca250e038c | |
| parent | 0b879f838f294f3908fa86ed75bd53b9fe1ea3d4 (diff) | |
| download | coreboot-9b860165bac4153517f46d655e5f67a25326214b.tar.xz | |
mptable: print ioapic entries
Print IOAPIC entry based on actual data, instead of giving the user
the feeling that the generated ioapic entry has any relation to reality.
If the IOAPIC entry in the MPTABLE is incorrect, the user will notice
it anyways. But adding a static entry (which might be also incorrect)
is even worse.
Change-Id: I6d0012324a9e6c7d22436ada36cbd3a4f7166f5c
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/1108
Tested-by: build bot (Jenkins)
| -rw-r--r-- | util/mptable/mptable.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/util/mptable/mptable.c b/util/mptable/mptable.c index 92ba544723..9488e36573 100644 --- a/util/mptable/mptable.c +++ b/util/mptable/mptable.c @@ -337,11 +337,6 @@ char *postamble[] = { 0 }; -char *ioapic_code[] = { -" smp_write_ioapic(mc, 2, 0x20, IO_APIC_ADDR);", -" /* TODO: If you have multiple IOAPICs, add them here. */", -0 -}; static void usage( void ) { @@ -831,8 +826,6 @@ MPConfigTableHeader( uint32_t pap ) totalSize -= basetableEntryTypes[ 2 ].length; } - write_code(ioapic_code); - /* process all the I/O Ints */ printf( "/*I/O Ints:\tType\tPolarity Trigger\tBus ID\t IRQ\tAPIC ID\tPIN#\n*/" ); for ( t = totalSize, c = count; c; c-- ) { @@ -1054,14 +1047,9 @@ ioApicEntry( void ) apics[ entry.apicID ] = entry.apicID; - // the numbering and setup of ioapics is so irrational - // that for now we will punt. -#if 0 if (entry.apicFlags & IOAPICENTRY_FLAG_EN) printf("\tsmp_write_ioapic(mc, 0x%x, 0x%x, 0x%x);\n", entry.apicID, entry.apicVersion, entry.apicAddress); -#endif - } |