diff options
| author | Felix Held <felix.held@amd.corp-partner.google.com> | 2020-04-12 02:17:44 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2020-04-13 12:38:30 +0000 |
| commit | a67c753d554c730c794726b1b65d07c9c383e264 (patch) | |
| tree | 8b335d01418142eeb70672e2762e963117ff8208 | |
| parent | da968d5f2eb702aecc8374a36faa7dc583e15f7f (diff) | |
| download | coreboot-a67c753d554c730c794726b1b65d07c9c383e264.tar.xz | |
soc/amd/picasso/soc_util: add TODO to Dali detection
Change-Id: I8ff5a9275d4cdf0049b63cc30b8a1cc376b50f80
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40321
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
| -rw-r--r-- | src/soc/amd/picasso/soc_util.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/soc/amd/picasso/soc_util.c b/src/soc/amd/picasso/soc_util.c index 893ff2570f..7cd050cae6 100644 --- a/src/soc/amd/picasso/soc_util.c +++ b/src/soc/amd/picasso/soc_util.c @@ -10,6 +10,10 @@ int soc_is_pollock(void) return soc_is_zen_plus() && CONFIG(AMD_FT5); } +/* + * TODO: This detection works for the Dali SKUs used in Chrome-devices, but fails for other + * Dali SKUs, since other Dali SKUs have a Zen+ CPUID and not a Raven2 one. + */ int soc_is_dali(void) { return soc_is_raven2() && CONFIG(AMD_FP5); |