diff options
| author | Patrick Georgi <patrick@georgi-clan.de> | 2014-12-29 20:41:37 +0100 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2015-01-03 23:58:25 +0100 |
| commit | ab639bffc7e973245e5f33397138ca8063c4123c (patch) | |
| tree | 1a3a7ecf5a6ee8ad14b531c49bba9768cc8a2321 | |
| parent | 3cb56e934f9e52597cb70caea3aa6c84f192d445 (diff) | |
| download | coreboot-ab639bffc7e973245e5f33397138ca8063c4123c.tar.xz | |
libpayload: don't test for unsigned >= 0
Change-Id: Ibeaf6de9505bc6f1e7358a4cfc80228dff7ddb69
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Found-by: Coverity Scan
Reviewed-on: http://review.coreboot.org/7978
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
| -rw-r--r-- | payloads/libpayload/drivers/video/corebootfb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/payloads/libpayload/drivers/video/corebootfb.c b/payloads/libpayload/drivers/video/corebootfb.c index f0f1007312..969c601733 100644 --- a/payloads/libpayload/drivers/video/corebootfb.c +++ b/payloads/libpayload/drivers/video/corebootfb.c @@ -197,7 +197,7 @@ static void corebootfb_update_cursor(void) paint = CHARS[cursor_y * coreboot_video_console.columns + cursor_x]; } - if (cursor_y >= 0 && cursor_y < coreboot_video_console.rows) + if (cursor_y < coreboot_video_console.rows) corebootfb_putchar(cursor_y, cursor_x, paint); } |