summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Roth <martinroth@google.com>2016-01-27 09:53:45 -0700
committerMartin Roth <martinroth@google.com>2016-01-29 16:56:31 +0100
commitb2cc1299af4af202069ef6fbbdb14a73bdff3b4f (patch)
tree281f68e672736ca370bebc74bcb91f6399983cf0
parentfbdc71941454cd4f6dbaebb3e38d27d11ab256ea (diff)
downloadcoreboot-b2cc1299af4af202069ef6fbbdb14a73bdff3b4f.tar.xz
board_status/getrevision.sh: get rid of colons in dir names
Gnu make won't build in directories that have a colon in their name. When the makefile expands a variable containing a dirctory name that has colons in it, it seems to interpret that as a makefile target, and fails the build. Many other characters also confuse the makefiles, including spaces, ampersand symbols, dollar signs, etc. I've started including scripts into the board-status directories to do the build of the rom that was tested, and this is preventing them from working without renaming the directory before doing the build. Change-Id: I9dd8e4027be21363015cd8df9918610e206afce2 Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: https://review.coreboot.org/13490 Tested-by: build bot (Jenkins) Reviewed-by: David Hendricks <dhendrix@chromium.org> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
-rwxr-xr-xutil/board_status/getrevision.sh5
1 files changed, 4 insertions, 1 deletions
diff --git a/util/board_status/getrevision.sh b/util/board_status/getrevision.sh
index 6559df3eb6..168c972f30 100755
--- a/util/board_status/getrevision.sh
+++ b/util/board_status/getrevision.sh
@@ -96,7 +96,10 @@ timestamp() {
if [ -z "$t" ]; then
echo "Warning: Could not determine timestamp." 2>/dev/null
fi
- echo "${t}"
+
+ # output the time, changing colons to underscores.
+ # gnu make doesn't work in directories with colons
+ echo "${t}" | tr ':' '_'
}
# Retrieve local SCM revision info. This is useful if we're working in a different SCM than upstream and/or