summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPrashant Malani <pmalani@chromium.org>2020-03-10 15:42:54 -0700
committerDuncan Laurie <dlaurie@chromium.org>2020-03-14 02:42:35 +0000
commitdabc0adb3af720c71e077f269c937c803580d6c6 (patch)
tree4e9ce11b9fa37faa00c0bdce875d56a8c060a17d
parent22d5b071607c301b3e7c563e16b2ecc915f864fd (diff)
downloadcoreboot-dabc0adb3af720c71e077f269c937c803580d6c6.tar.xz
ec/google/chromeec/acpi: Move ECPD under CREC
Move the ECPD (GOOG0003) device under CREC (GOOG0004) so that the ECPD AP device drivers can access the parent EC device to communicate with the EC. Also, update the Notify() call to reflect the new location of the ECPD device. Signed-off-by: Prashant Malani <pmalani@chromium.org> Change-Id: I830b030c7a063506f50f9cd51df3a5018e248fc2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/39469 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
-rw-r--r--src/ec/google/chromeec/acpi/cros_ec.asl4
-rw-r--r--src/ec/google/chromeec/acpi/ec.asl6
2 files changed, 5 insertions, 5 deletions
diff --git a/src/ec/google/chromeec/acpi/cros_ec.asl b/src/ec/google/chromeec/acpi/cros_ec.asl
index d41071e731..bcf38d2328 100644
--- a/src/ec/google/chromeec/acpi/cros_ec.asl
+++ b/src/ec/google/chromeec/acpi/cros_ec.asl
@@ -60,6 +60,10 @@ Device (CREC)
Name (_DDN, "EC Base Switch Device")
}
#endif
+
+#ifdef EC_ENABLE_PD_MCU_DEVICE
+ #include "pd.asl"
+#endif
Method(_STA, 0)
{
Return (0xB)
diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl
index bf792d3629..fa5eca6321 100644
--- a/src/ec/google/chromeec/acpi/ec.asl
+++ b/src/ec/google/chromeec/acpi/ec.asl
@@ -344,7 +344,7 @@ Device (EC0)
Method (_Q16, 0, NotSerialized)
{
Store ("EC: GOT PD EVENT", Debug)
- Notify (ECPD, 0x80)
+ Notify (\_SB.PCI0.LPCB.EC0.CREC.ECPD, 0x80)
}
#endif
@@ -558,10 +558,6 @@ Device (EC0)
#include "keyboard_backlight.asl"
#endif
-#ifdef EC_ENABLE_PD_MCU_DEVICE
- #include "pd.asl"
-#endif
-
#ifdef EC_ENABLE_TBMC_DEVICE
#include "tbmc.asl"
#endif